From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CAC3C43334 for ; Tue, 7 Jun 2022 08:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J+pqjsLAqmP9qgMFoPskrEm33IwVRSwqU+P+3fQYdmI=; b=OF6BOeVyw8wlMz eq1Ga3iddzjjk92hbFRNMRashkwZNqQdqyM3e6KGxKFEW4c4VhDn1Aiu8i7FBJa9WEryTv2y2lpPk OR0deeHvhadfzv4RBPOSdCvqz3HExRGG68LMUwoWjklFYDOniRcILcMyEESJRrj7z1q8J/DsbkStt oJAahmIgAl9vmJgS6m0s3D2cmTt9vuF2uI2uF2h9fqI6y53oKYF275IFbyv4RFros1g7e9BG0gmwS numqHKzZp+wtPCIGEMgOAx9p5RZA3EOH9DNutkkWIPvVrK+iZsSY7WOS2tigDK/aGAcQFbUEd/sA7 P6XYysHa2uAvaFy0V/Sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyUAx-005gT1-5n; Tue, 07 Jun 2022 08:02:55 +0000 Received: from mga05.intel.com ([192.55.52.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyU9z-005fxi-RD for linux-mtd@lists.infradead.org; Tue, 07 Jun 2022 08:02:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654588915; x=1686124915; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mQzWEDPxMO7UmRFxluiJ1Ca9g136QsEllPnrNDFo86E=; b=a/zZBKd6Ee61uIJQgG9jE4dQOV/jM++5Rrevde4LeOQAd6qLeYjwLK4l uiJUvKWgiy6qG7Bp0QMlJn4+tgiIWD81rkvF8EauqoH685GcBMbMZNO9i /KfqtTy2wkwAmt4PP7yB8aUKNycAUYTN5CJ0YoHZkWf7tgdhUKTXvxGgk xcNDgLEuSKGEYb+q/7P86WndJEKbQIYAkRTqGP/Y5MjTXETctlo1rCLyv HEyUnka4Gs0IE2Ynlm8KZZTcWI/OkYaj+YSUuRiToBfJqqux7kvsPOVE5 mkRHskEseK6QRkLVcZ8c91eS3pEpLrpCtoavTXxj+VtY2cgGWUG476gin A==; X-IronPort-AV: E=McAfee;i="6400,9594,10370"; a="363055336" X-IronPort-AV: E=Sophos;i="5.91,283,1647327600"; d="scan'208";a="363055336" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 01:01:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,283,1647327600"; d="scan'208";a="709385390" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by orsmga004.jf.intel.com with ESMTP; 07 Jun 2022 01:01:47 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1nyU9q-000DUT-Qe; Tue, 07 Jun 2022 08:01:46 +0000 Date: Tue, 7 Jun 2022 16:01:02 +0800 From: kernel test robot To: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-aio@kvack.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-mtd@lists.infradead.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 04/20] mm/migrate: Convert buffer_migrate_page() to buffer_migrate_folio() Message-ID: <202206071552.6lOdScLW-lkp@intel.com> References: <20220606204050.2625949-5-willy@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220606204050.2625949-5-willy@infradead.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220607_010155_974626_49DBF19F X-CRM114-Status: GOOD ( 13.73 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi "Matthew, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.19-rc1 next-20220607] [cannot apply to jaegeuk-f2fs/dev-test trondmy-nfs/linux-next kdave/for-next xfs-linux/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Wilcox-Oracle/Convert-aops-migratepage-to-aops-migrate_folio/20220607-044509 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f2906aa863381afb0015a9eb7fefad885d4e5a56 config: s390-randconfig-c005-20220606 (https://download.01.org/0day-ci/archive/20220607/202206071552.6lOdScLW-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b92436efcb7813fc481b30f2593a4907568d917a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install s390 cross compiling tool for clang build # apt-get install binutils-s390x-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/96e64ba8b1be545885d89f44b1d8b968b22bdb4d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Matthew-Wilcox-Oracle/Convert-aops-migratepage-to-aops-migrate_folio/20220607-044509 git checkout 96e64ba8b1be545885d89f44b1d8b968b22bdb4d # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> mm/migrate.c:775: warning: expecting prototype for buffer_migrate_folio_noref(). Prototype was for buffer_migrate_folio_norefs() instead vim +775 mm/migrate.c 89cb0888ca1483 Jan Kara 2018-12-28 758 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 759) /** 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 760) * buffer_migrate_folio_noref() - Migration function for folios with buffers. 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 761) * @mapping: The address space containing @src. 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 762) * @dst: The folio to migrate to. 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 763) * @src: The folio to migrate from. 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 764) * @mode: How to migrate the folio. 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 765) * 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 766) * Like buffer_migrate_folio() except that this variant is more careful 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 767) * and checks that there are also no buffer head references. This function 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 768) * is the right one for mappings where buffer heads are directly looked 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 769) * up and referenced (such as block device mappings). 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 770) * 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 771) * Return: 0 on success or a negative errno on failure. 89cb0888ca1483 Jan Kara 2018-12-28 772 */ 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 773) int buffer_migrate_folio_norefs(struct address_space *mapping, 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 774) struct folio *dst, struct folio *src, enum migrate_mode mode) 89cb0888ca1483 Jan Kara 2018-12-28 @775 { 96e64ba8b1be54 Matthew Wilcox (Oracle 2022-06-06 776) return __buffer_migrate_folio(mapping, dst, src, mode, true); 89cb0888ca1483 Jan Kara 2018-12-28 777 } 9361401eb7619c David Howells 2006-09-30 778 #endif 1d8b85ccf1ed53 Christoph Lameter 2006-06-23 779 -- 0-DAY CI Kernel Test Service https://01.org/lkp ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/