Re: [PATCH v5 3/3] mtd: nand: raw: qcom_nandc: reorder qcom_nand_host struct

Manivannan Sadhasivam
2022-06-09T07:23:27Z

On Wed, Jun 08, 2022 at 02:10:30AM +0200, Ansuel Smith wrote:
> Reorder qcom_nand_host to save holes in the struct.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>

If this patch gets moved to 2/3, you could save few changes. Also, do the same
for other structs as well.

Thanks,
Mani

> ---
> drivers/mtd/nand/raw/qcom_nandc.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index 06ee9a836a3b..110f839c9e51 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
> @@ -475,11 +475,13 @@ struct qcom_nand_host {
> int cs;
> int cw_size;
> int cw_data;
> - bool use_ecc;
> - bool bch_enabled;
> int ecc_bytes_hw;
> int spare_bytes;
> int bbm_size;
> +
> + bool codeword_fixup;
> + bool use_ecc;
> + bool bch_enabled;
> u8 status;
> int last_command;
>
> @@ -490,7 +492,6 @@ struct qcom_nand_host {
> u32 clrflashstatus;
> u32 clrreadstatus;
>
> - bool codeword_fixup;
> int nr_boot_partitions;
> struct qcom_nand_boot_partition *boot_partitions;
> };
> --
> 2.36.1
>

--
மணிவண்ணன் சதாசிவம்