From: Christian Marangi <ansuelsmth@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Christian Marangi <ansuelsmth@gmail.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: kernel test robot <oliver.sang@intel.com>, stable@vger.kernel.org
Subject: [PATCH] mtd: core: fix NULL pointer dereference with mtd_check_of_node
Date: Sun, 3 Jul 2022 11:56:31 +0200 [thread overview]
Message-ID: <20220703095631.16508-1-ansuelsmth@gmail.com> (raw)
Actually check if mtd dev have a parent to fix NULL pointer dereference
kernel panic in mtd_check_of_node.
Reported-by: kernel test robot <oliver.sang@intel.com>
Fixes: ad9b10d1eaad ("mtd: core: introduce of support for dynamic partitions")
Cc: stable@vger.kernel.org
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
drivers/mtd/mtdcore.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 6fafea80fd98..48a357fcf2ed 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -558,8 +558,12 @@ static void mtd_check_of_node(struct mtd_info *mtd)
if (dev_of_node(&mtd->dev))
return;
- /* Check if a partitions node exist */
+ /* Make sure we have a parent */
parent = mtd->parent;
+ if (!parent)
+ return;
+
+ /* Check if a partitions node exist */
parent_dn = dev_of_node(&parent->dev);
if (!parent_dn)
return;
--
2.36.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
reply other threads:[~2022-07-03 9:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220703095631.16508-1-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=oliver.sang@intel.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).