From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 952CAC433EF for ; Sat, 16 Jul 2022 09:40:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=myegFBQiOSvDmC7hSo2eXYELEuzyrsZ9ZMYl9HxAB6c=; b=Eu+SS3R8oN39F4 PP5f39BD0WE3d7QPpXEmxpYDNUoapLkhMAh0fygKAncCkQHTWcgRQ5KzkXreCxL9sinRSbrrGb3I6 CjE1BXvvwfQNqn/jmB/TEFV/ICOenqAgBDnSZwQyJzYQ8sVxETlgh9t+1kNVUoOFqz+1klaMd5x7U RU0vIjSawv4il3vtGees7tmXJUdWc5GSyqbNkFIlDn32bFHSJN6NOEnkwf/ygVrPOULFeVqdxhXyK Cme4HMtFoR4r7yoLkkc3HqGsc7eclkWPF4wFlel54/HwP2vn6sqFeabx5dYeVu0ztNasNKFTF8Nzl 2XaA0ydym35Iu8Q0IxpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCeHT-00F34I-12; Sat, 16 Jul 2022 09:40:11 +0000 Received: from smtp-out1.suse.de ([195.135.220.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCeGG-00F2At-7a; Sat, 16 Jul 2022 09:38:57 +0000 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 15F583467D; Sat, 16 Jul 2022 09:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657964333; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rjjB2Tj1v7P2/Hzk3+SDyFTeccso1IKFKW5WqPOEy9o=; b=FYLcjTomd9RwzKd0WH1grD27nlv90mrvwHhBqMpTwZ84b+ud/KCg/G66kuAwXewZT9WNZU KUoXV78aY9h0pGD3tU6wC1NUWMnnTut96DlEP8y9eH50+DJF9g9B7MqJejwpseg6NN+3AP aztwoEHqp/val4a46OzLLJze3puCCvw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657964333; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rjjB2Tj1v7P2/Hzk3+SDyFTeccso1IKFKW5WqPOEy9o=; b=4zswoA0zLnplqlg+Z+74ZePirnVjDWStv2fDsZyruYBHwedU1AwvfDaucAqi2kwIgvOWD+ zq/RYOljlEdPZGDQ== Received: from kitsune.suse.cz (kitsune.suse.cz [10.100.12.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 592212C141; Sat, 16 Jul 2022 09:38:51 +0000 (UTC) Date: Sat, 16 Jul 2022 11:38:50 +0200 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Michael Walle Cc: Pratyush Yadav , linux-sunxi@lists.linux.dev, Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH 1/2] mtd: spi-nor: When a flash memory is missing do not report an error Message-ID: <20220716093850.GL17705@kitsune.suse.cz> References: <701967b0c418db333c66b48d225df60aa9d03ead.1657826188.git.msuchanek@suse.de> <20220714205529.GE17705@kitsune.suse.cz> <33abf7b84860049c4a22605578303ff2@walle.cc> <20220714220744.GF17705@kitsune.suse.cz> <20220715092017.2ftoyzm22i4amrbt@ti.com> <20220716082027.GK17705@kitsune.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220716_023856_453254_87250260 X-CRM114-Status: GOOD ( 29.33 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Sat, Jul 16, 2022 at 11:30:12AM +0200, Michael Walle wrote: > Am 2022-07-16 10:20, schrieb Michal Such=E1nek: > = > > > So if DT says there isn't a flash on a specific CS when there is, then > > > DT should be fixed to describe the flash, and then we can probe it. > > > You > > > both seem to be saying the same thing here, and I agree. > > = > > The disagreement is about the situation when there is sometimes a flash > > chip. > = > No. The disagreement is what should happen if the DT says there is > a device but there isn't. Which right now is an error and it should > stay that way. Your hardware description says there is a flash > but it cannot be probed, so it is an error. What about a board > which has an actual error and the flash isn't responding? You > trade one use case for another. And what if you have a SATA controller with a bad cable? Or a bad connection to a mmc card? Then the kernel also does not say there is an error and simply does not see the device. This is normal. Not all devices that can potentially exist do exist. It is up to the user to decide if it's an error that the device is missing. > Also I've looked at the PHY subsystem and there, if a PHY is described > in the DT but isn't there, the following error will be printed: > dev_err(&mdio->dev, "MDIO device at address %d is missing.\n", addr); > = > And that is for a bus which can even be automatically be > probed/detected. If there is no use case for having a card with unpopulated PHY then it makes sense. Here we do have a use case so the comparison is moot. Thanks Michal ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/