Re: [PATCH 1/2] mtd: spi-nor: When a flash memory is missing do not report an error

kernel test robot
2022-07-15T00:44:53Z

Hi Michal,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mtd/spi-nor/next]
[also build test WARNING on sunxi/sunxi/for-next krzk/for-next krzk-dt/for-next krzk-mem-ctrl/for-next linus/master v5.19-rc6 next-20220714]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Michal-Suchanek/mtd-spi-nor-When-a-flash-memory-is-missing-do-not-report-an-error/20220715-032336
base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220715/202207150854.H5k2mIIu-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/d747dae258dd8d5220d38fae5fd09be703b0391b
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Michal-Suchanek/mtd-spi-nor-When-a-flash-memory-is-missing-do-not-report-an-error/20220715-032336
git checkout d747dae258dd8d5220d38fae5fd09be703b0391b
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/mtd/spi-nor/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/mtd/spi-nor/core.c:1655:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
1655 | static const bool buffer_uniform(const u8 *buffer, size_t length)
| ^~~~~

vim +1655 drivers/mtd/spi-nor/core.c

1654
> 1655 static const bool buffer_uniform(const u8 *buffer, size_t length)
1656 {
1657 bool all0;
1658 size_t i;
1659
1660 for (all0 = true, i = 0; i < length; i++)
1661 if (buffer[i] != 0) {
1662 all0 = false;
1663 break;
1664 }
1665 if (all0)
1666 return true;
1667 for (i = 0; i < length; i++)
1668 if (buffer[i] != 0xff)
1669 return false;
1670 return true;
1671 }
1672

--
0-DAY CI Kernel Test Service