public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: Scott Wood <oss@buserror.net>,
	u-boot@lists.denx.de, linux-mtd@lists.infradead.org
Subject: Re: Have fsl_elbc_nand controllers subpage write support?
Date: Sat, 13 Aug 2022 12:36:37 +0200	[thread overview]
Message-ID: <20220813103637.2qiikhitegxctlak@pali> (raw)
In-Reply-To: <20220807141300.tatzjlsjyhcxgegs@pali>

Hello!

On Sunday 07 August 2022 16:13:00 Pali Rohár wrote:
> On Sunday 07 August 2022 14:00:27 Pali Rohár wrote:
> > Hello Scott!
> > 
> > In past you disabled nand subpage write support for freescale eLBC and
> > IFC U-Boot nand drivers in following patch:
> > https://lore.kernel.org/u-boot/20121102234432.GA18129@buserror.net/
> > 
> > But in Linux kernel you disabled it only in freescale IFC nand driver:
> > https://lore.kernel.org/linux-mtd/20130410223437.GA26900@home.buserror.net/
> > 
> > letting kernel's freescale eLBC driver to have enabled subpage write
> > support.
> > 
> > I would like to ask, has freescale eLBC nand controller support for
> > subpage writes? Or not and it should be disabled also in kernel?
> > 
> > Or has somebody else these details?
> 
> Now I found following commit http://git.kernel.org/torvalds/c/f034d87def51
> which seems to be fixing/emulating subpage write support.

If there is not any objections I would send patch to U-boot eLBC nand
controller driver which would remove that NAND_NO_SUBPAGE_WRITE too. As
those subpage write functions are present also in U-Boot driver.

Any comments?

> > The main issue is that U-Boot nand and UBI support for boards with eLBC
> > controllers is compatible with Linux kernel nand and UBI support because
> > these two drivers calculate UBI geometry differently. UBI header offset
> > is calculated from nand subpage size and nand subpage size obviously
> > depends on the fact if subpage write is supported or not.
> > 
> > I would like to fix this issue, but I do not know if wrong information
> > is in U-Boot driver or in Linux kernel driver.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2022-08-13 10:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-07 12:00 Have fsl_elbc_nand controllers subpage write support? Pali Rohár
2022-08-07 14:13 ` Pali Rohár
2022-08-13 10:36   ` Pali Rohár [this message]
2022-08-15  8:06     ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220813103637.2qiikhitegxctlak@pali \
    --to=pali@kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=oss@buserror.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox