From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-kernel@vger.kernel.org>, <qemu-devel@nongnu.org>,
<linux-f2fs-devel@lists.sourceforge.net>,
<linux-erofs@lists.ozlabs.org>, <ocfs2-devel@oss.oracle.com>,
<linux-mtd@lists.infradead.org>, <amd-gfx@lists.freedesktop.org>
Cc: <gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<somlo@cmu.edu>, <mst@redhat.com>, <jaegeuk@kernel.org>,
<chao@kernel.org>, <hsiangkao@linux.alibaba.com>,
<huangjianan@oppo.com>, <mark@fasheh.com>, <jlbec@evilplan.org>,
<joseph.qi@linux.alibaba.com>, <akpm@linux-foundation.org>,
<alexander.deucher@amd.com>, <luben.tuikov@amd.com>,
<richard@nod.at>, <liushixin2@huawei.com>
Subject: [PATCH 01/11] kset: fix documentation for kset_register()
Date: Fri, 21 Oct 2022 10:20:52 +0800 [thread overview]
Message-ID: <20221021022102.2231464-2-yangyingliang@huawei.com> (raw)
In-Reply-To: <20221021022102.2231464-1-yangyingliang@huawei.com>
kset_register() is currently used in some places without calling
kset_put() in error path, because the callers think it should be
kset internal thing to do, but the driver core can not know what
caller doing with that memory at times. The memory could be freed
both in kset_put() and error path of caller, if it is called in
kset_register().
So make the function documentation more explicit about calling
kset_put() in the error path of caller.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
lib/kobject.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/kobject.c b/lib/kobject.c
index a0b2dbfcfa23..6da04353d974 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -834,6 +834,9 @@ EXPORT_SYMBOL_GPL(kobj_sysfs_ops);
/**
* kset_register() - Initialize and add a kset.
* @k: kset.
+ *
+ * If this function returns an error, kset_put() must be called to
+ * properly clean up the memory associated with the object.
*/
int kset_register(struct kset *k)
{
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-10-21 2:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 2:20 [PATCH 00/11] fix memory leak while kset_register() fails Yang Yingliang
2022-10-21 2:20 ` Yang Yingliang [this message]
2022-10-21 5:34 ` [PATCH 01/11] kset: fix documentation for kset_register() Luben Tuikov
2022-10-21 8:05 ` Yang Yingliang
2022-10-21 8:16 ` Greg KH
2022-10-21 8:18 ` Luben Tuikov
2022-10-21 2:20 ` [PATCH 02/11] kset: add null pointer check in kset_put() Yang Yingliang
2022-10-21 2:20 ` [PATCH 03/11] bus: fix possible memory leak in bus_register() Yang Yingliang
2022-10-21 2:20 ` [PATCH 04/11] kobject: fix possible memory leak in kset_create_and_add() Yang Yingliang
2022-10-21 2:20 ` [PATCH 05/11] class: fix possible memory leak in __class_register() Yang Yingliang
2022-10-21 2:20 ` [PATCH 06/11] firmware: qemu_fw_cfg: fix possible memory leak in fw_cfg_build_symlink() Yang Yingliang
2022-10-21 2:20 ` [PATCH 07/11] f2fs: fix possible memory leak in f2fs_init_sysfs() Yang Yingliang
2022-10-21 2:20 ` [PATCH 08/11] erofs: fix possible memory leak in erofs_init_sysfs() Yang Yingliang
2022-10-21 2:21 ` [PATCH 09/11] ocfs2: possible memory leak in mlog_sys_init() Yang Yingliang
2022-10-21 2:21 ` [PATCH 10/11] drm/amdgpu/discovery: fix possible memory leak Yang Yingliang
2022-10-21 2:21 ` [PATCH 11/11] ubifs: Fix memory leak in ubifs_sysfs_init() Yang Yingliang
2022-10-21 5:29 ` [PATCH 00/11] fix memory leak while kset_register() fails Luben Tuikov
2022-10-21 5:37 ` Greg KH
2022-10-21 7:55 ` Luben Tuikov
2022-10-21 8:18 ` Greg KH
2022-10-21 8:24 ` Luben Tuikov
2022-10-21 8:41 ` Luben Tuikov
2022-10-21 9:23 ` Yang Yingliang
2022-10-21 8:24 ` Yang Yingliang
2022-10-21 8:36 ` Greg KH
2022-10-21 8:52 ` Luben Tuikov
2022-10-21 8:59 ` Yang Yingliang
2022-10-21 9:08 ` Luben Tuikov
2022-10-21 9:56 ` Yang Yingliang
2022-10-21 23:45 ` Luben Tuikov
2022-10-21 9:12 ` Yang Yingliang
2022-10-21 23:48 ` Luben Tuikov
2022-10-21 7:25 ` Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021022102.2231464-2-yangyingliang@huawei.com \
--to=yangyingliang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=chao@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=huangjianan@oppo.com \
--cc=jaegeuk@kernel.org \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=liushixin2@huawei.com \
--cc=luben.tuikov@amd.com \
--cc=mark@fasheh.com \
--cc=mst@redhat.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=qemu-devel@nongnu.org \
--cc=rafael@kernel.org \
--cc=richard@nod.at \
--cc=somlo@cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox