From: Guenter Roeck <linux@roeck-us.net>
To: Michael Walle <michael@walle.cc>
Cc: Sudip Mukherjee <sudip.mukherjee@sifive.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <pratyush@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
greentime.hu@sifive.com, jude.onyenegecha@sifive.com,
william.salmon@sifive.com, adnan.chowdhury@sifive.com,
ben.dooks@sifive.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] mtd: spi-nor: issi: is25wp256: Init flash based on SFDP
Date: Wed, 21 Dec 2022 04:16:47 -0800 [thread overview]
Message-ID: <20221221121647.GA1353152@roeck-us.net> (raw)
In-Reply-To: <9cf53ca3bfb39c85da968f9b46dbe6d7@walle.cc>
Hi Michael,
On Wed, Dec 21, 2022 at 09:22:04AM +0100, Michael Walle wrote:
> Hi,
>
> Am 2022-12-21 01:30, schrieb Guenter Roeck:
> > With this patch in place, qemu emulations with is25wp256 fail to
> > instantiate the flash. Specifically, this affects the qemu sifive_u
> > emulation. The resulting error message is:
> >
> > spi-nor spi0.0: BFPT parsing failed. Please consider using
> > SPI_NOR_SKIP_SFDP when declaring the flash
> > spi-nor: probe of spi0.0 failed with error -22
>
> qemu is to blame here. It doesn't fully emulate the flash. Esp. not
> the SFDP tables. See also [1]. Adding the .sfdp_read hook with the
> corresponding binary [2] should fix your issue.
>
> [1]
> https://lore.kernel.org/qemu-devel/7827c791b7f91f4eb216b33473dd6103@walle.cc/
> [2] https://lore.kernel.org/linux-mtd/CAHyZL-ch=mr0x_19e6P9G+Z4sW2iJXW9nTnXUNAhn+pTptN2ww@mail.gmail.com/
>
Great, that helped. I'll prepare and send a qemu patch.
Thanks,
Guenter
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-12-21 12:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 18:48 [PATCH v3 1/2] mtd: spi-nor: issi: is25wp256: Init flash based on SFDP Sudip Mukherjee
2022-09-20 18:48 ` [PATCH v3 2/2] mtd: spi-nor: add SFDP fixups for Quad Page Program Sudip Mukherjee
2022-09-20 18:52 ` Sudip Mukherjee
2022-09-20 18:51 ` [PATCH v3 1/2] mtd: spi-nor: issi: is25wp256: Init flash based on SFDP Sudip Mukherjee
2022-09-22 14:19 ` Michael Walle
2022-09-23 18:31 ` Sudip Mukherjee
2022-11-22 10:26 ` Tudor Ambarus
2022-12-21 0:30 ` Guenter Roeck
2022-12-21 7:03 ` Tudor Ambarus
2022-12-21 8:49 ` Tudor Ambarus
2022-12-21 8:22 ` Michael Walle
2022-12-21 12:16 ` Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-20 18:47 Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221221121647.GA1353152@roeck-us.net \
--to=linux@roeck-us.net \
--cc=adnan.chowdhury@sifive.com \
--cc=ben.dooks@sifive.com \
--cc=greentime.hu@sifive.com \
--cc=jude.onyenegecha@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=sudip.mukherjee@sifive.com \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
--cc=william.salmon@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox