From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Michael Walle <michael@walle.cc>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] mtd: Avoid printing error messages on probe deferrals
Date: Wed, 8 Mar 2023 14:54:41 +0100 [thread overview]
Message-ID: <20230308145441.2dc96ddb@xps-13> (raw)
In-Reply-To: <5ff078a1f994c87621cc9ea9335ff6b6@walle.cc>
Hi Michael,
michael@walle.cc wrote on Tue, 07 Mar 2023 21:35:05 +0100:
> Am 2023-03-07 20:25, schrieb Miquel Raynal:
> > There is no reason to complain about probe errors in case of deferrals.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > Changes in v2:
> > * Use of dev_err_probe().
> >
> > drivers/mtd/mtdcore.c | 9 ++++-----
> > 1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> > index 0feacb9fbdac..e4e102585021 100644
> > --- a/drivers/mtd/mtdcore.c
> > +++ b/drivers/mtd/mtdcore.c
> > @@ -536,12 +536,11 @@ static int mtd_nvmem_add(struct mtd_info *mtd)
> > mtd->nvmem = nvmem_register(&config);
> > if (IS_ERR(mtd->nvmem)) {
> > /* Just ignore if there is no NVMEM support in the kernel */
> > - if (PTR_ERR(mtd->nvmem) == -EOPNOTSUPP) {
> > + if (PTR_ERR(mtd->nvmem) == -EOPNOTSUPP)
> > mtd->nvmem = NULL;
> > - } else {
> > - dev_err(&mtd->dev, "Failed to register NVMEM device\n");
> > - return PTR_ERR(mtd->nvmem);
> > - }
> > + else
> > + return dev_err_probe(&mtd->dev, PTR_ERR(mtd->nvmem),
>
> There is a '\t' after the ",".
Mmmh, didn't notice, will fix it while applying.
>
> With that fixed,
> Reviewed-by: Michael Walle <michael@walle.cc>
>
> -michael
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-03-08 13:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 19:25 [PATCH v2] mtd: Avoid printing error messages on probe deferrals Miquel Raynal
2023-03-07 20:35 ` Michael Walle
2023-03-08 13:54 ` Miquel Raynal [this message]
2023-03-20 11:17 ` Rafał Miłecki
2023-03-20 11:23 ` Miquel Raynal
2023-03-21 12:35 ` Rafał Miłecki
2023-03-21 12:37 ` Rafał Miłecki
2023-03-22 16:08 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308145441.2dc96ddb@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox