linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: JaimeLiao <jaimeliao.tw@gmail.com>, linux-mtd@lists.infradead.org
Subject: Re: Boot failed after patch "mtd: rawnand: Support for sequential cache reads"
Date: Fri, 26 May 2023 20:14:20 +0200	[thread overview]
Message-ID: <20230526201420.231092a0@xps-13> (raw)
In-Reply-To: <CAP1tNvS=NVAm-vfvYWbc3k9Cx9YxMc2uZZkmXk8h1NhGX877Zg@mail.gmail.com>

Hi Alexander,

eagle.alexander923@gmail.com wrote on Thu, 25 May 2023 10:48:39 +0300:

> Hello.
> 
> Kernel boot fails after patch "mtd: rawnand: Support for sequential
> cache reads" (thanks to git bisect).
> Please advise what can be done here and where to look for a bug.

Thanks for the report, and sorry for the trouble. Right now I don't
know what's wrong with the driver but as a first step, you could just
try to reset chip->controller->supported_op.cont_read after
rawnand_check_cont_read_support(). It should just avoid using the
optimization and solve the boot. That's of course a very early fix, we
now need to understand further what's going on.

My first guess would be that the sequential read patterns are not
supported by the controller or badly implemented by its driver. But
that is strange given the simplicity of this controller. This
controller is meant to be versatile, I doubt it does not support these
operations. Plus, I would expect page accesses to be directly
implemented by the driver and not be affected by this logic. Could you
try to trace the actual calls which are made through the mtd layer
which lead to these errors? Is ->exec_op() involved in the process?
Where? How?

Also, what kernel are you using exactly? I'm surprised there is no
mtd-related error. If you reboot with an older kernel, you get your
data, right?

Otherwise maybe the Micron chip is in fault. Which would mean that
there are unsupported commands. I believed they were all standard,
maybe some of them are optional? Could you check in the chip datasheet
if there is any command used there that is unsupported?

> 
> Thanks.
> 
> ...
> omap-gpmc 50000000.gpmc: GPMC revision 6.0
> ...
> nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xda
> nand: Micron MT29F2G08ABAEAWP
> nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64
> nand: using OMAP_ECC_BCH8_CODE_HW ECC scheme
> ...
> VFS: Mounted root (squashfs filesystem) readonly on device 254:0.
> devtmpfs: mounted
> Freeing unused kernel image (initmem) memory: 1024K
> Run /sbin/init as init process
> SQUASHFS error: lzo decompression failed, data probably corrupt
> SQUASHFS error: Failed to read block 0xd291c2: -5
> SQUASHFS error: lzo decompression failed, data probably corrupt
> SQUASHFS error: Failed to read block 0xd291c2: -5
> SQUASHFS error: Unable to read data cache entry [d291c2]
> SQUASHFS error: Unable to read page, block d291c2, size 14307
> SQUASHFS error: Unable to read data cache entry [d291c2]
> SQUASHFS error: Unable to read page, block d291c2, size 14307
> Kernel panic - not syncing: Attempted to kill init!
> exitcode=0x00000007 CPU: 0 PID: 1 Comm: init Not tainted 6.3.0+ #105
> Hardware name: Generic AM33XX (Flattened Device Tree)
>  unwind_backtrace from show_stack+0xb/0xc
>  show_stack from dump_stack_lvl+0x2b/0x34
>  dump_stack_lvl from panic+0xbd/0x230
>  panic from make_task_dead+0x1/0x120
>  make_task_dead from 0xc102ca80
> ---[ end Kernel panic - not syncing: Attempted to kill init!
> exitcode=0x00000007 ]---


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2023-05-26 18:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25  7:48 Boot failed after patch "mtd: rawnand: Support for sequential cache reads" Alexander Shiyan
2023-05-26 18:14 ` Miquel Raynal [this message]
2023-05-29  6:10   ` Alexander Shiyan
2023-05-29  8:12     ` Miquel Raynal
2023-05-29 10:33       ` Alexander Shiyan
2023-05-29 11:46         ` Miquel Raynal
2023-05-30 14:48           ` [EXT] " Bean Huo
2023-05-31  9:02             ` Alexander Shiyan
2023-06-01  7:37               ` Miquel Raynal
2023-06-01 16:55                 ` Bean Huo
2023-06-02  9:52                   ` Alexander Shiyan
2023-06-05  8:39                     ` Miquel Raynal
2023-06-05 15:45                       ` Bean Huo
2023-06-26  9:22                         ` Bean Huo
2023-07-03  9:16                           ` Alexander Shiyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230526201420.231092a0@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=eagle.alexander923@gmail.com \
    --cc=jaimeliao.tw@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).