From: Conor Dooley <conor@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Pratyush Yadav" <ptyadav@amazon.de>,
"Dhruva Gole" <d-gole@ti.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2] dt-bindings: mtd: partitions: Include TP-Link SafeLoader in allowed list
Date: Sat, 3 Jun 2023 11:10:28 +0100 [thread overview]
Message-ID: <20230603-flyover-amperage-83a3d3bc7d85@spud> (raw)
In-Reply-To: <20230602215629.2568-1-zajec5@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1148 bytes --]
On Fri, Jun 02, 2023 at 11:56:29PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> It's supposed to be there and it's needed for proper validation of DTS
> files.
>
> This fixes following errors for Northstar based TP-Link routers:
> bcm47081-tplink-archer-c5-v2.dtb: flash@0: partitions:compatible: 'oneOf' conditional failed, one must be fixed:
> ['tplink,safeloader-partitions'] is too short
> 'fixed-partitions' was expected
> 'sercomm,sc-partitions' was expected
> 'arm,arm-firmware-suite' was expected
> 'brcm,bcm4908-partitions' was expected
> 'brcm,bcm947xx-cfe-partitions' was expected
> 'linksys,ns-partitions' was expected
> 'qcom,smem-part' was expected
> 'redboot-fis' was expected
Something like this would have been sufficient, dumping the whole error
into the commit message bloats it for no real gain, but I was asking for
you to say what the issue was, not asking for a resubmission (yet anyway).
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-06-03 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 21:56 [PATCH V2] dt-bindings: mtd: partitions: Include TP-Link SafeLoader in allowed list Rafał Miłecki
2023-06-03 10:10 ` Conor Dooley [this message]
2023-06-09 15:27 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230603-flyover-amperage-83a3d3bc7d85@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=d-gole@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=ptyadav@amazon.de \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox