* [PATCH v2 0/2] mtd: spi-nor: Support for another sst flash
@ 2023-06-16 14:08 Miquel Raynal
2023-06-16 14:08 ` [PATCH v2 1/2] mtd: spi-nor: Add support for sst26vf032b flash Miquel Raynal
2023-06-16 14:08 ` [PATCH v2 2/2] mtd: spi-nor: Drop redundant information on the sst26vf flash series Miquel Raynal
0 siblings, 2 replies; 6+ messages in thread
From: Miquel Raynal @ 2023-06-16 14:08 UTC (permalink / raw)
To: Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
Pratyush Yadav, Michael Walle, linux-mtd
Cc: Thomas Petazzoni, Miquel Raynal
Hello,
Here are a couple of patches adding support for the sst26vf032b spi-nor,
I could successfully use the PARSE_SFDP flag actually, so here is a
second patch actually switching to SFDP parsing for its cousins as
well.
Cheers,
Miquèl
Changes in v2:
* Drop the useless binding change.
* Add Link tag in commit message.
* Use the PARSE_SFDP flag.
* Drop redundant information from the known parts and its cousin.
Miquel Raynal (2):
mtd: spi-nor: Add support for sst26vf032b flash
mtd: spi-nor: Drop redundant information on the sst26vf flash series
drivers/mtd/spi-nor/sst.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
--
2.34.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] mtd: spi-nor: Add support for sst26vf032b flash
2023-06-16 14:08 [PATCH v2 0/2] mtd: spi-nor: Support for another sst flash Miquel Raynal
@ 2023-06-16 14:08 ` Miquel Raynal
2023-06-19 8:18 ` Tudor Ambarus
2023-06-16 14:08 ` [PATCH v2 2/2] mtd: spi-nor: Drop redundant information on the sst26vf flash series Miquel Raynal
1 sibling, 1 reply; 6+ messages in thread
From: Miquel Raynal @ 2023-06-16 14:08 UTC (permalink / raw)
To: Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
Pratyush Yadav, Michael Walle, linux-mtd
Cc: Thomas Petazzoni, Miquel Raynal
Describe this new part. The datasheet is public.
Link: https://ww1.microchip.com/downloads/aemDocuments/documents/MPD/ProductDocuments/DataSheets/SST26VF032B-SST26VF032BA-2.5V-3.0V-32-Mbit-Serial-Quad-IO-%28SQI%29-Flash-Memory-20005218K.pdf
Here are the sfdp tables plus base testing to show it works.
$ cat /sys/bus/spi/devices/spi0.0/spi-nor/partname
sst26vf032b
$ cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id
bf2642
$ cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer
sst
$ xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
53464450060102ff00060110300000ff81000106000100ffbf0001180002
0001fffffffffffffffffffffffffffffffffd20f1ffffffff0144eb086b
083b80bbfeffffffffff00ffffff440b0c200dd80fd810d820914824806f
1d81ed0f773830b030b0f7ffffff29c25cfff030c080ffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffff0004fff37f0000f57f0000f9ff
3d00f57f0000f37f0000ffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffbf2642ffb95ffdff30f260f332ff0a122346ff0f19320f1919ffffff
ffffffff00669938ff05013506040232b03072428de89888a585c09faf5a
ffff06ec060c0003080bffffffffff07ffff0202ff060300fdfd040600fc
0300fefe0202070e
$ md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
e7efddddb3d5ee89ca37bf6b6e789645 /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
$ dd if=/dev/urandom of=./qspi_test bs=1M count=1
1+0 records in
1+0 records out
$ mtd_debug write /dev/mtd0 0 1048576 qspi_test
Copied 1048576 bytes from qspi_test to address 0x00000000 in flash
$ mtd_debug erase /dev/mtd0 0 1048576
Erased 1048576 bytes from address 0x00000000 in flash
$ mtd_debug read /dev/mtd0 0 1048576 qspi_read
Copied 1048576 bytes from address 0x00000000 in flash to qspi_read
$ hexdump qspi_read
0000000 ffff ffff ffff ffff ffff ffff ffff ffff
*
0100000
$ mtd_debug write /dev/mtd0 0 1048576 qspi_test
Copied 1048576 bytes from qspi_test to address 0x00000000 in flash
$ mtd_debug read /dev/mtd0 0 1048576 qspi_read
Copied 1048576 bytes from address 0x00000000 in flash to qspi_read
$ sha1sum qspi_test qspi_read
2f2f191c7a937eca5db21a1c39e79e7327587cc1 qspi_test
2f2f191c7a937eca5db21a1c39e79e7327587cc1 qspi_read
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
drivers/mtd/spi-nor/sst.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c
index 99c8a19493f5..48970d2f78fa 100644
--- a/drivers/mtd/spi-nor/sst.c
+++ b/drivers/mtd/spi-nor/sst.c
@@ -113,6 +113,10 @@ static const struct flash_info sst_nor_parts[] = {
FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ)
.fixups = &sst26vf_nor_fixups },
+ { "sst26vf032b", INFO(0xbf2642, 0, 0, 0)
+ FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
+ PARSE_SFDP
+ .fixups = &sst26vf_nor_fixups },
{ "sst26vf064b", INFO(0xbf2643, 0, 64 * 1024, 128)
FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
--
2.34.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] mtd: spi-nor: Drop redundant information on the sst26vf flash series
2023-06-16 14:08 [PATCH v2 0/2] mtd: spi-nor: Support for another sst flash Miquel Raynal
2023-06-16 14:08 ` [PATCH v2 1/2] mtd: spi-nor: Add support for sst26vf032b flash Miquel Raynal
@ 2023-06-16 14:08 ` Miquel Raynal
2023-06-19 8:20 ` Tudor Ambarus
1 sibling, 1 reply; 6+ messages in thread
From: Miquel Raynal @ 2023-06-16 14:08 UTC (permalink / raw)
To: Richard Weinberger, Vignesh Raghavendra, Tudor Ambarus,
Pratyush Yadav, Michael Walle, linux-mtd
Cc: Thomas Petazzoni, Miquel Raynal
It seems like the whole sst26vf flash series share the exact same
properties, beside the final size due to a lower/higher number of blocks
in the final die. As the intermediate version fully supports SFDP
parsing, we assume the others as well.
Drop the redundant information and use the PARSE_SFDP flag instead.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
drivers/mtd/spi-nor/sst.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c
index 48970d2f78fa..467154176dd6 100644
--- a/drivers/mtd/spi-nor/sst.c
+++ b/drivers/mtd/spi-nor/sst.c
@@ -109,17 +109,17 @@ static const struct flash_info sst_nor_parts[] = {
{ "sst26wf016b", INFO(0xbf2651, 0, 64 * 1024, 32)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ) },
- { "sst26vf016b", INFO(0xbf2641, 0, 64 * 1024, 32)
+ { "sst26vf016b", INFO(0xbf2641, 0, 0, 0)
FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
- NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ)
+ PARSE_SFDP
.fixups = &sst26vf_nor_fixups },
{ "sst26vf032b", INFO(0xbf2642, 0, 0, 0)
FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
PARSE_SFDP
.fixups = &sst26vf_nor_fixups },
- { "sst26vf064b", INFO(0xbf2643, 0, 64 * 1024, 128)
+ { "sst26vf064b", INFO(0xbf2643, 0, 0, 0)
FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
- NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
+ PARSE_SFDP
.fixups = &sst26vf_nor_fixups },
};
--
2.34.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] mtd: spi-nor: Add support for sst26vf032b flash
2023-06-16 14:08 ` [PATCH v2 1/2] mtd: spi-nor: Add support for sst26vf032b flash Miquel Raynal
@ 2023-06-19 8:18 ` Tudor Ambarus
2023-07-12 16:13 ` Miquel Raynal
0 siblings, 1 reply; 6+ messages in thread
From: Tudor Ambarus @ 2023-06-19 8:18 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Pratyush Yadav, Michael Walle, linux-mtd
Cc: Thomas Petazzoni
Hi, Miquel,
On 6/16/23 15:08, Miquel Raynal wrote:
> Describe this new part. The datasheet is public.
>
> Link: https://ww1.microchip.com/downloads/aemDocuments/documents/MPD/ProductDocuments/DataSheets/SST26VF032B-SST26VF032BA-2.5V-3.0V-32-Mbit-Serial-Quad-IO-%28SQI%29-Flash-Memory-20005218K.pdf
>
> Here are the sfdp tables plus base testing to show it works.
>
> $ cat /sys/bus/spi/devices/spi0.0/spi-nor/partname
> sst26vf032b
> $ cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id
> bf2642
> $ cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer
> sst
> $ xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
> 53464450060102ff00060110300000ff81000106000100ffbf0001180002
> 0001fffffffffffffffffffffffffffffffffd20f1ffffffff0144eb086b
> 083b80bbfeffffffffff00ffffff440b0c200dd80fd810d820914824806f
> 1d81ed0f773830b030b0f7ffffff29c25cfff030c080ffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffff0004fff37f0000f57f0000f9ff
> 3d00f57f0000f37f0000ffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffbf2642ffb95ffdff30f260f332ff0a122346ff0f19320f1919ffffff
> ffffffff00669938ff05013506040232b03072428de89888a585c09faf5a
> ffff06ec060c0003080bffffffffff07ffff0202ff060300fdfd040600fc
> 0300fefe0202070e
> $ md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
> e7efddddb3d5ee89ca37bf6b6e789645 /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
>
> $ dd if=/dev/urandom of=./qspi_test bs=1M count=1
> 1+0 records in
> 1+0 records out
> $ mtd_debug write /dev/mtd0 0 1048576 qspi_test
> Copied 1048576 bytes from qspi_test to address 0x00000000 in flash
> $ mtd_debug erase /dev/mtd0 0 1048576
> Erased 1048576 bytes from address 0x00000000 in flash
> $ mtd_debug read /dev/mtd0 0 1048576 qspi_read
> Copied 1048576 bytes from address 0x00000000 in flash to qspi_read
> $ hexdump qspi_read
> 0000000 ffff ffff ffff ffff ffff ffff ffff ffff
> *
> 0100000
> $ mtd_debug write /dev/mtd0 0 1048576 qspi_test
> Copied 1048576 bytes from qspi_test to address 0x00000000 in flash
> $ mtd_debug read /dev/mtd0 0 1048576 qspi_read
> Copied 1048576 bytes from address 0x00000000 in flash to qspi_read
> $ sha1sum qspi_test qspi_read
> 2f2f191c7a937eca5db21a1c39e79e7327587cc1 qspi_test
> 2f2f191c7a937eca5db21a1c39e79e7327587cc1 qspi_read
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> drivers/mtd/spi-nor/sst.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c
> index 99c8a19493f5..48970d2f78fa 100644
> --- a/drivers/mtd/spi-nor/sst.c
> +++ b/drivers/mtd/spi-nor/sst.c
> @@ -113,6 +113,10 @@ static const struct flash_info sst_nor_parts[] = {
> FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ)
> .fixups = &sst26vf_nor_fixups },
> + { "sst26vf032b", INFO(0xbf2642, 0, 0, 0)
> + FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
> + PARSE_SFDP
> + .fixups = &sst26vf_nor_fixups },
> { "sst26vf064b", INFO(0xbf2643, 0, 64 * 1024, 128)
> FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
Looks good to me, I'll queue it for 6.6.
Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] mtd: spi-nor: Drop redundant information on the sst26vf flash series
2023-06-16 14:08 ` [PATCH v2 2/2] mtd: spi-nor: Drop redundant information on the sst26vf flash series Miquel Raynal
@ 2023-06-19 8:20 ` Tudor Ambarus
0 siblings, 0 replies; 6+ messages in thread
From: Tudor Ambarus @ 2023-06-19 8:20 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Pratyush Yadav, Michael Walle, linux-mtd
Cc: Thomas Petazzoni
On 6/16/23 15:08, Miquel Raynal wrote:
> It seems like the whole sst26vf flash series share the exact same
> properties, beside the final size due to a lower/higher number of blocks
> in the final die. As the intermediate version fully supports SFDP
> parsing, we assume the others as well.
I think the changes are fine, but I'm not going to queue things
that are not tested. I saw too many things to rely on assumptions.
All these will be changed one at a time when we have hw on our hands.
>
> Drop the redundant information and use the PARSE_SFDP flag instead.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> drivers/mtd/spi-nor/sst.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c
> index 48970d2f78fa..467154176dd6 100644
> --- a/drivers/mtd/spi-nor/sst.c
> +++ b/drivers/mtd/spi-nor/sst.c
> @@ -109,17 +109,17 @@ static const struct flash_info sst_nor_parts[] = {
> { "sst26wf016b", INFO(0xbf2651, 0, 64 * 1024, 32)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
> - { "sst26vf016b", INFO(0xbf2641, 0, 64 * 1024, 32)
> + { "sst26vf016b", INFO(0xbf2641, 0, 0, 0)
> FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
> - NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ)
> + PARSE_SFDP
> .fixups = &sst26vf_nor_fixups },
> { "sst26vf032b", INFO(0xbf2642, 0, 0, 0)
> FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
> PARSE_SFDP
> .fixups = &sst26vf_nor_fixups },
> - { "sst26vf064b", INFO(0xbf2643, 0, 64 * 1024, 128)
> + { "sst26vf064b", INFO(0xbf2643, 0, 0, 0)
> FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
> - NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
> + PARSE_SFDP
> .fixups = &sst26vf_nor_fixups },
> };
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] mtd: spi-nor: Add support for sst26vf032b flash
2023-06-19 8:18 ` Tudor Ambarus
@ 2023-07-12 16:13 ` Miquel Raynal
0 siblings, 0 replies; 6+ messages in thread
From: Miquel Raynal @ 2023-07-12 16:13 UTC (permalink / raw)
To: Tudor Ambarus
Cc: Richard Weinberger, Vignesh Raghavendra, Pratyush Yadav,
Michael Walle, linux-mtd, Thomas Petazzoni
Hi Tudor,
tudor.ambarus@linaro.org wrote on Mon, 19 Jun 2023 09:18:08 +0100:
> Hi, Miquel,
>
> On 6/16/23 15:08, Miquel Raynal wrote:
> > Describe this new part. The datasheet is public.
> >
> > Link: https://ww1.microchip.com/downloads/aemDocuments/documents/MPD/ProductDocuments/DataSheets/SST26VF032B-SST26VF032BA-2.5V-3.0V-32-Mbit-Serial-Quad-IO-%28SQI%29-Flash-Memory-20005218K.pdf
> >
> > Here are the sfdp tables plus base testing to show it works.
> >
> > $ cat /sys/bus/spi/devices/spi0.0/spi-nor/partname
> > sst26vf032b
> > $ cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id
> > bf2642
> > $ cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer
> > sst
> > $ xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
> > 53464450060102ff00060110300000ff81000106000100ffbf0001180002
> > 0001fffffffffffffffffffffffffffffffffd20f1ffffffff0144eb086b
> > 083b80bbfeffffffffff00ffffff440b0c200dd80fd810d820914824806f
> > 1d81ed0f773830b030b0f7ffffff29c25cfff030c080ffffffffffffffff
> > ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> > ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> > ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> > ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> > ffffffffffffffffffffffffffffffffff0004fff37f0000f57f0000f9ff
> > 3d00f57f0000f37f0000ffffffffffffffffffffffffffffffffffffffff
> > ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> > ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> > ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> > ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> > ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> > ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> > ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> > ffffbf2642ffb95ffdff30f260f332ff0a122346ff0f19320f1919ffffff
> > ffffffff00669938ff05013506040232b03072428de89888a585c09faf5a
> > ffff06ec060c0003080bffffffffff07ffff0202ff060300fdfd040600fc
> > 0300fefe0202070e
> > $ md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
> > e7efddddb3d5ee89ca37bf6b6e789645 /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
> >
> > $ dd if=/dev/urandom of=./qspi_test bs=1M count=1
> > 1+0 records in
> > 1+0 records out
> > $ mtd_debug write /dev/mtd0 0 1048576 qspi_test
> > Copied 1048576 bytes from qspi_test to address 0x00000000 in flash
> > $ mtd_debug erase /dev/mtd0 0 1048576
> > Erased 1048576 bytes from address 0x00000000 in flash
> > $ mtd_debug read /dev/mtd0 0 1048576 qspi_read
> > Copied 1048576 bytes from address 0x00000000 in flash to qspi_read
> > $ hexdump qspi_read
> > 0000000 ffff ffff ffff ffff ffff ffff ffff ffff
> > *
> > 0100000
> > $ mtd_debug write /dev/mtd0 0 1048576 qspi_test
> > Copied 1048576 bytes from qspi_test to address 0x00000000 in flash
> > $ mtd_debug read /dev/mtd0 0 1048576 qspi_read
> > Copied 1048576 bytes from address 0x00000000 in flash to qspi_read
> > $ sha1sum qspi_test qspi_read
> > 2f2f191c7a937eca5db21a1c39e79e7327587cc1 qspi_test
> > 2f2f191c7a937eca5db21a1c39e79e7327587cc1 qspi_read
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > drivers/mtd/spi-nor/sst.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c
> > index 99c8a19493f5..48970d2f78fa 100644
> > --- a/drivers/mtd/spi-nor/sst.c
> > +++ b/drivers/mtd/spi-nor/sst.c
> > @@ -113,6 +113,10 @@ static const struct flash_info sst_nor_parts[] = {
> > FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
> > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ)
> > .fixups = &sst26vf_nor_fixups },
> > + { "sst26vf032b", INFO(0xbf2642, 0, 0, 0)
> > + FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
> > + PARSE_SFDP
> > + .fixups = &sst26vf_nor_fixups },
> > { "sst26vf064b", INFO(0xbf2643, 0, 64 * 1024, 128)
> > FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE)
> > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
>
>
> Looks good to me, I'll queue it for 6.6.
It does not apply anymore on -rc1, I'll send you an update so you don't
have to care about the conflict.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-12 16:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-16 14:08 [PATCH v2 0/2] mtd: spi-nor: Support for another sst flash Miquel Raynal
2023-06-16 14:08 ` [PATCH v2 1/2] mtd: spi-nor: Add support for sst26vf032b flash Miquel Raynal
2023-06-19 8:18 ` Tudor Ambarus
2023-07-12 16:13 ` Miquel Raynal
2023-06-16 14:08 ` [PATCH v2 2/2] mtd: spi-nor: Drop redundant information on the sst26vf flash series Miquel Raynal
2023-06-19 8:20 ` Tudor Ambarus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).