* [PATCH] mtd: rawnand: brcmnand: propagate init error -EPROBE_DEFER up
@ 2023-07-18 16:33 Rafał Miłecki
2023-07-19 8:24 ` Miquel Raynal
0 siblings, 1 reply; 3+ messages in thread
From: Rafał Miłecki @ 2023-07-18 16:33 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: Brian Norris, Kamal Dasu, linux-mtd, bcm-kernel-feedback-list,
Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
MTD subsystem may return -EPROBE_DEFER if something isn't ready yet.
It's important to pass that error up so device will get probed later.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index 39661e23d7d4..cca2b153ae26 100644
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -3245,6 +3245,8 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
ret = brcmnand_init_cs(host, NULL);
if (ret) {
+ if (ret == -EPROBE_DEFER)
+ goto err;
devm_kfree(dev, host);
continue; /* Try all chip-selects */
}
--
2.35.3
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: rawnand: brcmnand: propagate init error -EPROBE_DEFER up
2023-07-18 16:33 [PATCH] mtd: rawnand: brcmnand: propagate init error -EPROBE_DEFER up Rafał Miłecki
@ 2023-07-19 8:24 ` Miquel Raynal
2023-07-19 8:38 ` Rafał Miłecki
0 siblings, 1 reply; 3+ messages in thread
From: Miquel Raynal @ 2023-07-19 8:24 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Richard Weinberger, Vignesh Raghavendra, Brian Norris, Kamal Dasu,
linux-mtd, bcm-kernel-feedback-list, Rafał Miłecki
Hi Rafał,
zajec5@gmail.com wrote on Tue, 18 Jul 2023 18:33:31 +0200:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> MTD subsystem may return -EPROBE_DEFER if something isn't ready yet.
> It's important to pass that error up so device will get probed later.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> index 39661e23d7d4..cca2b153ae26 100644
> --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
> @@ -3245,6 +3245,8 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
>
> ret = brcmnand_init_cs(host, NULL);
> if (ret) {
> + if (ret == -EPROBE_DEFER)
> + goto err;
Don't we need an of_node_put(child) here?
> devm_kfree(dev, host);
> continue; /* Try all chip-selects */
> }
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: rawnand: brcmnand: propagate init error -EPROBE_DEFER up
2023-07-19 8:24 ` Miquel Raynal
@ 2023-07-19 8:38 ` Rafał Miłecki
0 siblings, 0 replies; 3+ messages in thread
From: Rafał Miłecki @ 2023-07-19 8:38 UTC (permalink / raw)
To: Miquel Raynal
Cc: Rafał Miłecki, Richard Weinberger, Vignesh Raghavendra,
Brian Norris, Kamal Dasu, linux-mtd, bcm-kernel-feedback-list
On 2023-07-19 10:24, Miquel Raynal wrote:
> Hi Rafał,
>
> zajec5@gmail.com wrote on Tue, 18 Jul 2023 18:33:31 +0200:
>
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> MTD subsystem may return -EPROBE_DEFER if something isn't ready yet.
>> It's important to pass that error up so device will get probed later.
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> ---
>> drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
>> b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
>> index 39661e23d7d4..cca2b153ae26 100644
>> --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
>> +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
>> @@ -3245,6 +3245,8 @@ int brcmnand_probe(struct platform_device *pdev,
>> struct brcmnand_soc *soc)
>>
>> ret = brcmnand_init_cs(host, NULL);
>> if (ret) {
>> + if (ret == -EPROBE_DEFER)
>> + goto err;
>
> Don't we need an of_node_put(child) here?
Good catch!
>> devm_kfree(dev, host);
>> continue; /* Try all chip-selects */
>> }
>
>
> Thanks,
> Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-19 8:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-18 16:33 [PATCH] mtd: rawnand: brcmnand: propagate init error -EPROBE_DEFER up Rafał Miłecki
2023-07-19 8:24 ` Miquel Raynal
2023-07-19 8:38 ` Rafał Miłecki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).