Re: [PATCH 8/8] mtd: rawnand: qcom: Fix address parsing within ->exec_op()

Miquel Raynal
2023-07-28T07:56:43Z

Hi Tudor,

tudor.ambarus@linaro.org wrote on Fri, 28 Jul 2023 03:31:41 +0100:

> Hi, Miquel,
>
> On 7/27/23 15:59, Miquel Raynal wrote:
> > Hi Sadre,
> >
> > mani@kernel.org wrote on Mon, 17 Jul 2023 12:08:43 +0530:
> >
> >> On Sun, Jul 16, 2023 at 04:46:12PM +0200, Miquel Raynal wrote:
> >>> The naddrs variable is initialized but not used. Fixing this could have
> >>> been a matter of dropping the variable, but the right way to do it looks
> >>> a bit more complex: we can avoid useless writes to the q_op structure by
> >>> using it. In practice we could even have possible out-of-bound bugs with
> >>> the existing implementation. Let's fix all that by just performing the
> >>> right number of assignments in the addr{1,2}_reg fields.
> >>>
> >>> Fixes: 89550beb098e ("mtd: rawnand: qcom: Implement exec_op()")
> >>> Reported-by: kernel test robot <lkp@intel.com>
> >>> Closes: https://lore.kernel.org/oe-kbuild-all/202307131959.PdPSC86K-lkp@intel.com/
> >>> Closes: https://lore.kernel.org/oe-kbuild-all/202307131730.NOYbcjBr-lkp@intel.com/
> >>> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> >> LGTM! But I'm relying on Sadre to test it.
> >>
> >> Acked-by: Manivannan Sadhasivam <mani@kernel.org>
> > I don't think I've received feedback from Sadre, I would like to close
> > these issues, can you please test and give us feedback?
>
> All patches are pretty straight forward. Let the 0-day bot run with them
> and then apply all if no further feedback.

Thanks a lot for all the review! Fortunately I just received the
Tested-by, otherwise I agree most patches are simple enough (besides
the last one maybe) and 0-day might have done a good first iteration.

Thanks,
Miquèl