From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64DE2EB64DD for ; Fri, 28 Jul 2023 22:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/aE1pjJI3WRJ3A9Qq2IjzG1o/Wu0Ml/G9E6/WPZDKa0=; b=tdq0gA6y/7hyaX kdi7kb5Jh127vy+cNUwjSK2obDNIsrnvqg2qetoPhiDxbNHhGgdGjeBxJzyuUzsOyWgapJmpfegFQ tMTge9mH0JKHsfbky86KiE/kJ2tC9W/xICKtYvVx1JKWW2YLWOW21K121knhL56mfqf9Wo88HgffP gpopTYAMMrEcZR4l6NpBvVVqZ2V1new2wsMA2rORXI1Tr4SW+tgjCkloLIj7W5xR/9ujSjGzfQp1f 6HMkPh/l2IK3Q9wzFAe46cxdXngtqKH7IqO/rxJ6bWJhhJQqyAUDNp7kdBDY8uF7Tm/U0Jd0uKnFh 2kV9siuisp511B2xntgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qPWPE-005PTI-0B; Fri, 28 Jul 2023 22:57:56 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qPWPA-005PSZ-2G for linux-mtd@lists.infradead.org; Fri, 28 Jul 2023 22:57:54 +0000 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1b8ad907ba4so17080055ad.0 for ; Fri, 28 Jul 2023 15:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1690585067; x=1691189867; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OqGEzOR5r6kH79o9SwA25U8njOcawYVrofop3YQ6YUY=; b=fiGthZSlKO+TzVRMFQ/lllIkD1Hxo0n//085ngVGHX+MFVacNMT3jIfwGlotRfqjgi 7/P2vA/h8L+veUta3UBM+pWIrJvHr/5k6/Rjn4abuIqxwd7smLlUVI8+sxAVHHkqY9Dm ClG4EhRzY0307ShUnA4g6h5b+AA+GZOvaUXcc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690585067; x=1691189867; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OqGEzOR5r6kH79o9SwA25U8njOcawYVrofop3YQ6YUY=; b=hJ2RNPi8uAlRR1qdQyUtt0iJqVVVoEXKK9FSd2Xab8j6ehSnXelk01X7TbVmzOmRDL hBbnCadZGki6EaEYbKG6Vg4E4SHOC9F+hsrJdVA0dC9k2JEUb84N9ly2CUFXBPJWXJy1 caNKQC2oTjl/nbAJekYpz7UhxfxsXqFx6LUeMY1M/QR0VboMrWLzVVkPj1A3bPYx/IxB sjT2G7in56a1Du7m6CFCOfMwTdxWPMfqhjQbraZSqPq/55o4VpdnRTPsuBJ+Rec/I7F/ 5HlmfVdDLvWp97i1ZMkIuYQtWiSFpR/vYXBF0uNikB672E/fjeD6IxE5sJQAieHJKCiB hnJA== X-Gm-Message-State: ABy/qLZYypuNSnDBlK9ZKJaPtngl2CEBc5sChuJ15+sX50iovACCY7K9 Gdzx8lTt2OcNtmh9YwuxER4hT7mSvHmjo7PEH3w= X-Google-Smtp-Source: APBJJlFOw6OVfT4p2CaNm9atJ1j4OmKSy9hELnlIdDyAntpjKQSdNnE2D3nHAe//JnmbkZEc3Ervlw== X-Received: by 2002:a17:902:c405:b0:1bb:a85f:4645 with SMTP id k5-20020a170902c40500b001bba85f4645mr3324239plk.15.1690585067446; Fri, 28 Jul 2023 15:57:47 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id p4-20020a170902eac400b001bb9b87ac95sm4082927pld.103.2023.07.28.15.57.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 15:57:46 -0700 (PDT) Date: Fri, 28 Jul 2023 15:57:45 -0700 From: Kees Cook To: Geert Uytterhoeven Cc: linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org, linux-wireless@vger.kernel.org, linux-mips@vger.kernel.org, linux-mtd@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: Build regressions/improvements in v6.5-rc3 Message-ID: <202307281551.D894AA39@keescook> References: <20230724122626.1701631-1-geert@linux-m68k.org> <88f83d73-781d-bdc-126-aa629cb368c@linux-m68k.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <88f83d73-781d-bdc-126-aa629cb368c@linux-m68k.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230728_155752_782590_753B4F4E X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, Jul 24, 2023 at 02:43:02PM +0200, Geert Uytterhoeven wrote: > On Mon, 24 Jul 2023, Geert Uytterhoeven wrote: > > JFYI, when comparing v6.5-rc3[1] to v6.5-rc2[3], the summaries are: > > - build errors: +5/-0 > > + /kisskb/src/include/linux/fortify-string.h: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]: => 583:25, 493:25 > > mips-gcc13/mips-allmodconfig > > Full context: > > In function 'fortify_memset_chk', > inlined from 'memset_io' at /kisskb/src/arch/mips/include/asm/io.h:486:2, > inlined from 'build_auth_frame' at /kisskb/src/drivers/net/wireless/legacy/ray_cs.c:2697:2: > /kisskb/src/include/linux/fortify-string.h:493:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning] > 493 | __write_overflow_field(p_size_field, size); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In function 'fortify_memcpy_chk', > inlined from 'memcpy_toio' at /kisskb/src/arch/mips/include/asm/io.h:494:2, > inlined from 'translate_frame' at /kisskb/src/drivers/net/wireless/legacy/ray_cs.c:955:3, > inlined from 'ray_hw_xmit.constprop' at /kisskb/src/drivers/net/wireless/legacy/ray_cs.c:912:12: > /kisskb/src/include/linux/fortify-string.h:583:25: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning] > 583 | __write_overflow_field(p_size_field, size); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Single-element flexible array abuse in drivers/net/wireless/legacy/rayctl.h:tx_msg.var ^^^^ is this line from you or is there a tool outputting this? Because, yes, very true: struct tx_msg { struct tib_structure tib; struct phy_header phy; struct mac_header mac; UCHAR var[1]; }; I'll send a patch. -- Kees Cook ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/