From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Martin Kurbanov <mmkurbanov@sberdevices.ru>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
<linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
<kernel@sberdevices.ru>
Subject: Re: [PATCH v2 2/2] mtd: spinand: micron: fixing the offset for OOB
Date: Wed, 23 Aug 2023 10:41:43 +0200 [thread overview]
Message-ID: <20230823104143.760cc5bc@xps-13> (raw)
In-Reply-To: <01925ff8-1d19-a729-429a-89866fad319f@sberdevices.ru>
Hi Martin,
mmkurbanov@sberdevices.ru wrote on Tue, 22 Aug 2023 19:57:11 +0300:
> Hi Miquel,
>
> On 22.08.2023 16:35, Miquel Raynal wrote:
> > Hi Martin,
> >
> > mmkurbanov@sberdevices.ru wrote on Tue, 22 Aug 2023 15:25:34 +0300:
> >
> >> The first 4 bytes are reserved for bad block data.
> >
> > Are you sure about that? I've never seen 4-bytes BBM.
>
> Yes, I'm sure. I have checked in all the relevant datasheets:
> ----------------------------------------------------------------------------------
> | Name | Max Byte | Min Byte | Area | Description |
> | | Address | Address | | |
> |--------------------+----------+----------+---------+---------------------------|
> | MT29F2G01ABAGD [1] | | | | |
> |--------------------| | | | |
> | MT29F2G01ABBGD [2] | | | | |
> |--------------------| 803h | 800h | | |
> | MT29F1G01ABAFD [3] | | | | |
> |--------------------| | | | |
> | MT29F4G01ADAGD [4] | | | | |
> |--------------------+----------+----------| Spare 0 | Reserved (bad block data) |
> | MT29F4G01ABAFD [5] | | | | |
> |--------------------| | | | |
> | MT29F4G01ABBFD [6] | | | | |
> |--------------------| 1003h | 1000h | | |
> | MT29F8G01ADAFD [7] | | | | |
> |--------------------| | | | |
> | MT29F8G01ADBFD [8] | | | | |
> ----------------------------------------------------------------------------------
>
> Note: to view the datasheet on the Micron (https://www.micron.com/) website, you need
> to register.
I don't think the four bytes have any "bad block specific" meaning. In
practice, the datasheet states:
Value programmed for bad block at the first byte of spare
area: 00h
So only the first byte is used to mark the block bad, the rest is
probably marked "reserved" for simplicity. I believe we should keep the
current layout because it would otherwise break users for no real
reason.
> Links:
> [1] https://datasheet.lcsc.com/lcsc/1912111437_Micron-Tech-MT29F2G01ABAGDWB-IT-G_C410863.pdf - page 45
> [2] https://www.micron.com/-/media/client/global/documents/products/data-sheet/nand-flash/70-series/m79a_2gb_1_8v_nand_spi.pdf - page 46
> [3] https://datasheet.lcsc.com/lcsc/2209201030_Micron-Tech-MT29F1G01ABAFDWB-IT-F_C2905686.pdf - page 46
> [4] https://www.micron.com/-/media/client/global/documents/products/data-sheet/nand-flash/70-series/m79a_ddp_4gb_3v_nand_spi.pdf - page 46
> [5] https://www.micron.com/-/media/client/global/documents/products/data-sheet/nand-flash/70-series/m70a_4gb_3v_nand_spi.pdf - page 47
> [6] https://www.micron.com/-/media/client/global/documents/products/data-sheet/nand-flash/70-series/m70a_4gb_1_8v_nand_spi.pdf - page 49
> [7] https://www.micron.com/-/media/client/global/documents/products/data-sheet/nand-flash/70-series/m70a_ddp_8gb_3v_nand_spi.pdf - page 48
> [8] https://www.micron.com/-/media/client/global/documents/products/data-sheet/nand-flash/70-series/m70a_ddp_8gb_1_8v_nand_spi.pdf - page 48
>
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-08-23 8:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 12:25 [PATCH v2 0/2] mtd: spinand: micron: correct parameters Martin Kurbanov
2023-08-22 12:25 ` [PATCH v2 1/2] mtd: spinand: micron: correct bitmask for ecc status Martin Kurbanov
2023-08-22 12:30 ` Frieder Schrempf
2023-08-22 12:25 ` [PATCH v2 2/2] mtd: spinand: micron: fixing the offset for OOB Martin Kurbanov
2023-08-22 12:32 ` Frieder Schrempf
2023-08-22 13:35 ` Miquel Raynal
2023-08-22 16:57 ` Martin Kurbanov
2023-08-23 8:41 ` Miquel Raynal [this message]
2023-08-23 11:33 ` Martin Kurbanov
2023-08-23 11:39 ` Miquel Raynal
2023-08-24 9:35 ` Martin Kurbanov
2023-09-04 14:20 ` Martin Kurbanov
2023-09-04 14:31 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230823104143.760cc5bc@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=kernel@sberdevices.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mmkurbanov@sberdevices.ru \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox