From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Bibek Kumar Patro <quic_bibekkum@quicinc.com>
Cc: <mani@kernel.org>, <richard@nod.at>, <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel@quicinc.com>,
<quic_charante@quicinc.com>, <quic_kaushalk@quicinc.com>,
<quic_pkondeti@quicinc.com>
Subject: Re: [PATCH v4] mtd: rawnand: qcom: Unmap the right resource upon probe failure
Date: Tue, 12 Sep 2023 14:28:47 +0200 [thread overview]
Message-ID: <20230912142847.4610c0a0@xps-13> (raw)
In-Reply-To: <20230912115903.1007-1-quic_bibekkum@quicinc.com>
Hi Bibek,
quic_bibekkum@quicinc.com wrote on Tue, 12 Sep 2023 17:29:03 +0530:
> We currently provide the physical address of the DMA region
> rather than the output of dma_map_resource() which is obviously wrong.
>
> Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()")
Cc: stable?
> Signed-off-by: Bibek Kumar Patro <quic_bibekkum@quicinc.com>
> ---
> v4: Incorporated suggestion from Miquel
> - Modified title and commit description.
>
> v3: Incorporated comments from Miquel
> - Modified the commit message and title as per suggestions.
> https://lore.kernel.org/all/20230912101814.7748-1-quic_bibekkum@quicinc.com/
>
> v2: Incorporated comments from Pavan/Mani.
> https://lore.kernel.org/all/20230911133026.29868-1-quic_bibekkum@quicinc.com/
>
> v1: https://lore.kernel.org/all/20230907092854.11408-1-quic_bibekkum@quicinc.com/
>
> drivers/mtd/nand/raw/qcom_nandc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index 64499c1b3603..b079605c84d3 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
> @@ -3444,7 +3444,7 @@ static int qcom_nandc_probe(struct platform_device *pdev)
> err_aon_clk:
> clk_disable_unprepare(nandc->core_clk);
> err_core_clk:
> - dma_unmap_resource(dev, res->start, resource_size(res),
> + dma_unmap_resource(dev, nandc->base_dma, resource_size(res),
> DMA_BIDIRECTIONAL, 0);
> return ret;
> }
> --
> 2.17.1
>
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-09-12 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 11:59 [PATCH v4] mtd: rawnand: qcom: Unmap the right resource upon probe failure Bibek Kumar Patro
2023-09-12 12:28 ` Miquel Raynal [this message]
2023-09-12 14:32 ` Bibek Kumar Patro
2023-09-12 14:37 ` Manivannan Sadhasivam
2023-09-13 7:08 ` Bibek Kumar Patro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912142847.4610c0a0@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=kernel@quicinc.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mani@kernel.org \
--cc=quic_bibekkum@quicinc.com \
--cc=quic_charante@quicinc.com \
--cc=quic_kaushalk@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox