[PATCH v2 0/6] remove AR7 platform and associated drivers

[PATCH v2 0/6] remove AR7 platform and associated drivers

[Wolfram Sang]

Changes since v1:
* kept uapi define for for serial port type
* added acks

Still valid cover letter from v1:

When trying to get rid of the obsolete VLYNQ bus, Jonas and Florian
pointed out that its only user, the AR7 platform can probaly go entirely
[1]. This series does exactly that. Even OpenWRT has removed support
because these devices are "stuck with 3.18" [2].

It removes the drivers first, because watchdog and network include
platform specific headers. Once the drivers are gone, we remove the
platform. The patches are based on 6.6-rc2 and created with
"--irreversible-delete" to save some space.

My suggestion is that everything is merged via the MIPS tree in one go,
so we don't have broken drivers because of missing platform headers. But
maybe there are reasons for a two-cycle removal with the drivers first
and the platform later?

Looking forward to comments.

Happy hacking,

   Wolfram


[1] https://lore.kernel.org/r/3395161f-2543-46f0-83d9-b918800305e1@gmail.com
[2] https://openwrt.org/docs/techref/targets/ar7


Wolfram Sang (6):
  serial: 8250: remove AR7 support
  mtd: parsers: ar7: remove support
  vlynq: remove bus driver
  watchdog: ar7_wdt: remove driver to prepare for platform removal
  net: cpmac: remove driver to prepare for platform removal
  MIPS: AR7: remove platform

 MAINTAINERS                             |   13 -
 arch/arm/configs/pxa_defconfig          |    1 -
 arch/mips/Kbuild.platforms              |    1 -
 arch/mips/Kconfig                       |   22 -
 arch/mips/ar7/Makefile                  |   11 -
 arch/mips/ar7/Platform                  |    5 -
 arch/mips/ar7/clock.c                   |  439 --------
 arch/mips/ar7/gpio.c                    |  332 ------
 arch/mips/ar7/irq.c                     |  165 ---
 arch/mips/ar7/memory.c                  |   51 -
 arch/mips/ar7/platform.c                |  722 -------------
 arch/mips/ar7/prom.c                    |  256 -----
 arch/mips/ar7/setup.c                   |   93 --
 arch/mips/ar7/time.c                    |   31 -
 arch/mips/boot/compressed/uart-16550.c  |    5 -
 arch/mips/configs/ar7_defconfig         |  119 ---
 arch/mips/include/asm/mach-ar7/ar7.h    |  191 ----
 arch/mips/include/asm/mach-ar7/irq.h    |   16 -
 arch/mips/include/asm/mach-ar7/prom.h   |   12 -
 arch/mips/include/asm/mach-ar7/spaces.h |   22 -
 drivers/Kconfig                         |    2 -
 drivers/Makefile                        |    1 -
 drivers/mtd/parsers/Kconfig             |    5 -
 drivers/mtd/parsers/Makefile            |    1 -
 drivers/mtd/parsers/ar7part.c           |  129 ---
 drivers/net/ethernet/ti/Kconfig         |    9 +-
 drivers/net/ethernet/ti/Makefile        |    1 -
 drivers/net/ethernet/ti/cpmac.c         | 1251 -----------------------
 drivers/tty/serial/8250/8250_port.c     |    7 -
 drivers/vlynq/Kconfig                   |   21 -
 drivers/vlynq/Makefile                  |    6 -
 drivers/vlynq/vlynq.c                   |  799 ---------------
 drivers/watchdog/Kconfig                |    6 -
 drivers/watchdog/Makefile               |    1 -
 drivers/watchdog/ar7_wdt.c              |  315 ------
 include/linux/vlynq.h                   |  149 ---
 36 files changed, 1 insertion(+), 5209 deletions(-)
 delete mode 100644 arch/mips/ar7/Makefile
 delete mode 100644 arch/mips/ar7/Platform
 delete mode 100644 arch/mips/ar7/clock.c
 delete mode 100644 arch/mips/ar7/gpio.c
 delete mode 100644 arch/mips/ar7/irq.c
 delete mode 100644 arch/mips/ar7/memory.c
 delete mode 100644 arch/mips/ar7/platform.c
 delete mode 100644 arch/mips/ar7/prom.c
 delete mode 100644 arch/mips/ar7/setup.c
 delete mode 100644 arch/mips/ar7/time.c
 delete mode 100644 arch/mips/configs/ar7_defconfig
 delete mode 100644 arch/mips/include/asm/mach-ar7/ar7.h
 delete mode 100644 arch/mips/include/asm/mach-ar7/irq.h
 delete mode 100644 arch/mips/include/asm/mach-ar7/prom.h
 delete mode 100644 arch/mips/include/asm/mach-ar7/spaces.h
 delete mode 100644 drivers/mtd/parsers/ar7part.c
 delete mode 100644 drivers/net/ethernet/ti/cpmac.c
 delete mode 100644 drivers/vlynq/Kconfig
 delete mode 100644 drivers/vlynq/Makefile
 delete mode 100644 drivers/vlynq/vlynq.c
 delete mode 100644 drivers/watchdog/ar7_wdt.c
 delete mode 100644 include/linux/vlynq.h

-- 
2.35.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

[PATCH v2 2/6] mtd: parsers: ar7: remove support

[Wolfram Sang]

AR7 is going to be removed from the Kernel, so remove its support for
MTD.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes since v1:
* added ack

 arch/arm/configs/pxa_defconfig |   1 -
 drivers/mtd/parsers/Kconfig    |   5 --
 drivers/mtd/parsers/Makefile   |   1 -
 drivers/mtd/parsers/ar7part.c  | 129 ---------------------------------
 4 files changed, 136 deletions(-)
 delete mode 100644 drivers/mtd/parsers/ar7part.c

diff --git a/arch/arm/configs/pxa_defconfig b/arch/arm/configs/pxa_defconfig
index 23c131b0854b..9e81b1849e4c 100644
--- a/arch/arm/configs/pxa_defconfig
+++ b/arch/arm/configs/pxa_defconfig
@@ -100,7 +100,6 @@ CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_CONNECTOR=y
 CONFIG_MTD=y
-CONFIG_MTD_AR7_PARTS=m
 CONFIG_MTD_CMDLINE_PARTS=m
 CONFIG_MTD_OF_PARTS=m
 CONFIG_MTD_AFS_PARTS=m
diff --git a/drivers/mtd/parsers/Kconfig b/drivers/mtd/parsers/Kconfig
index 60738edcd5d5..da03ab6efe04 100644
--- a/drivers/mtd/parsers/Kconfig
+++ b/drivers/mtd/parsers/Kconfig
@@ -1,9 +1,4 @@
 # SPDX-License-Identifier: GPL-2.0-only
-config MTD_AR7_PARTS
-	tristate "TI AR7 partitioning parser"
-	help
-	  TI AR7 partitioning parser support
-
 config MTD_BCM47XX_PARTS
 	tristate "BCM47XX partitioning parser"
 	depends on BCM47XX || ARCH_BCM_5301X
diff --git a/drivers/mtd/parsers/Makefile b/drivers/mtd/parsers/Makefile
index 0e70b621a1d8..9b00c62b837a 100644
--- a/drivers/mtd/parsers/Makefile
+++ b/drivers/mtd/parsers/Makefile
@@ -1,5 +1,4 @@
 # SPDX-License-Identifier: GPL-2.0-only
-obj-$(CONFIG_MTD_AR7_PARTS)		+= ar7part.o
 obj-$(CONFIG_MTD_BCM47XX_PARTS)		+= bcm47xxpart.o
 obj-$(CONFIG_MTD_BCM63XX_PARTS)		+= bcm63xxpart.o
 obj-$(CONFIG_MTD_BRCM_U_BOOT)		+= brcm_u-boot.o
diff --git a/drivers/mtd/parsers/ar7part.c b/drivers/mtd/parsers/ar7part.c
deleted file mode 100644
index 8cd683711ac6..000000000000
-- 
2.35.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH v2 2/6] mtd: parsers: ar7: remove support

[Miquel Raynal]

Hi Wolfram,

wsa+renesas@sang-engineering.com wrote on Fri, 22 Sep 2023 08:15:23
+0200:

> AR7 is going to be removed from the Kernel, so remove its support for
> MTD.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Changes since v1:
> * added ack
> 
>  arch/arm/configs/pxa_defconfig |   1 -

I'm not sure it is wise to merge defconfig changes through mtd. Would
you mind sending this change aside to avoid potential conflicts? Each
patch can live on their own anyway.

>  drivers/mtd/parsers/Kconfig    |   5 --
>  drivers/mtd/parsers/Makefile   |   1 -
>  drivers/mtd/parsers/ar7part.c  | 129 ---------------------------------

Do you have other changes related to this file in your tree? It failed
to apply on my side.

>  4 files changed, 136 deletions(-)
>  delete mode 100644 drivers/mtd/parsers/ar7part.c

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH v2 2/6] mtd: parsers: ar7: remove support

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 733 bytes --]


> I'm not sure it is wise to merge defconfig changes through mtd. Would
> you mind sending this change aside to avoid potential conflicts? Each
> patch can live on their own anyway.

Yup, I can send a seperate patch for it.

> >  drivers/mtd/parsers/Kconfig    |   5 --
> >  drivers/mtd/parsers/Makefile   |   1 -
> >  drivers/mtd/parsers/ar7part.c  | 129 ---------------------------------
> 
> Do you have other changes related to this file in your tree? It failed
> to apply on my side.

No change. Plain v6.6-rc2. I used "--irreversible-delete", though. Maybe
this is causing issues? As I stated in the cover-letter, I wonder if all
this should go via MIPS. But there hasn't been any discussion about it
yet.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH v2 2/6] mtd: parsers: ar7: remove support

[Philippe Mathieu-Daudé]

On 22/9/23 19:55, Wolfram Sang wrote:
> 
>> I'm not sure it is wise to merge defconfig changes through mtd. Would
>> you mind sending this change aside to avoid potential conflicts? Each
>> patch can live on their own anyway.
> 
> Yup, I can send a seperate patch for it.
> 
>>>   drivers/mtd/parsers/Kconfig    |   5 --
>>>   drivers/mtd/parsers/Makefile   |   1 -
>>>   drivers/mtd/parsers/ar7part.c  | 129 ---------------------------------
>>
>> Do you have other changes related to this file in your tree? It failed
>> to apply on my side.
> 
> No change. Plain v6.6-rc2. I used "--irreversible-delete", though. Maybe
> this is causing issues? As I stated in the cover-letter, I wonder if all
> this should go via MIPS. But there hasn't been any discussion about it
> yet.

MIPS tree for the whole series certainly makes sense.


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH v2 2/6] mtd: parsers: ar7: remove support

[Miquel Raynal]

Hi,

philmd@linaro.org wrote on Fri, 22 Sep 2023 20:35:16 +0200:

> On 22/9/23 19:55, Wolfram Sang wrote:
> >   
> >> I'm not sure it is wise to merge defconfig changes through mtd. Would
> >> you mind sending this change aside to avoid potential conflicts? Each
> >> patch can live on their own anyway.  
> > 
> > Yup, I can send a seperate patch for it.
> >   
> >>>   drivers/mtd/parsers/Kconfig    |   5 --
> >>>   drivers/mtd/parsers/Makefile   |   1 -
> >>>   drivers/mtd/parsers/ar7part.c  | 129 ---------------------------------  
> >>
> >> Do you have other changes related to this file in your tree? It failed
> >> to apply on my side.  
> > 
> > No change. Plain v6.6-rc2. I used "--irreversible-delete", though. Maybe
> > this is causing issues? As I stated in the cover-letter, I wonder if all
> > this should go via MIPS. But there hasn't been any discussion about it
> > yet.  
> 
> MIPS tree for the whole series certainly makes sense.

Then:

Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH v2 2/6] mtd: parsers: ar7: remove support

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 385 bytes --]


> I'm not sure it is wise to merge defconfig changes through mtd. Would
> you mind sending this change aside to avoid potential conflicts? Each
> patch can live on their own anyway.

I checked pxa_defconfig history. Most commits in the last 7 years were
just removing outdated Kconfig symbols from all kind of subsystems. Like
what we want to do here. I think it is okay to keep it.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH v2 2/6] mtd: parsers: ar7: remove support

[Miquel Raynal]

Hi Wolfram,

wsa+renesas@sang-engineering.com wrote on Thu, 28 Sep 2023 09:10:24
+0200:

> > I'm not sure it is wise to merge defconfig changes through mtd. Would
> > you mind sending this change aside to avoid potential conflicts? Each
> > patch can live on their own anyway.  
> 
> I checked pxa_defconfig history. Most commits in the last 7 years were
> just removing outdated Kconfig symbols from all kind of subsystems. Like
> what we want to do here. I think it is okay to keep it.
> 

Ok, I've acked the patch anyway, so now I expect it to be taken through
the mips tree as suggested earlier. Let me know if it's happening
differently.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH v2 0/6] remove AR7 platform and associated drivers

[Thomas Bogendoerfer]

On Fri, Sep 22, 2023 at 08:15:21AM +0200, Wolfram Sang wrote:
> Changes since v1:
> * kept uapi define for for serial port type
> * added acks
> 
> Still valid cover letter from v1:
> 
> When trying to get rid of the obsolete VLYNQ bus, Jonas and Florian
> pointed out that its only user, the AR7 platform can probaly go entirely
> [1]. This series does exactly that. Even OpenWRT has removed support
> because these devices are "stuck with 3.18" [2].
> 
> It removes the drivers first, because watchdog and network include
> platform specific headers. Once the drivers are gone, we remove the
> platform. The patches are based on 6.6-rc2 and created with
> "--irreversible-delete" to save some space.
> 
> My suggestion is that everything is merged via the MIPS tree in one go,
> so we don't have broken drivers because of missing platform headers. But
> maybe there are reasons for a two-cycle removal with the drivers first
> and the platform later?
> 
> Looking forward to comments.
> 
> Happy hacking,
> 
>    Wolfram
> 
> 
> [1] https://lore.kernel.org/r/3395161f-2543-46f0-83d9-b918800305e1@gmail.com
> [2] https://openwrt.org/docs/techref/targets/ar7
> 
> 
> Wolfram Sang (6):
>   serial: 8250: remove AR7 support
>   mtd: parsers: ar7: remove support
>   vlynq: remove bus driver
>   watchdog: ar7_wdt: remove driver to prepare for platform removal
>   net: cpmac: remove driver to prepare for platform removal
>   MIPS: AR7: remove platform
> 
>  MAINTAINERS                             |   13 -
>  arch/arm/configs/pxa_defconfig          |    1 -
>  arch/mips/Kbuild.platforms              |    1 -
>  arch/mips/Kconfig                       |   22 -
>  arch/mips/ar7/Makefile                  |   11 -
>  arch/mips/ar7/Platform                  |    5 -
>  arch/mips/ar7/clock.c                   |  439 --------
>  arch/mips/ar7/gpio.c                    |  332 ------
>  arch/mips/ar7/irq.c                     |  165 ---
>  arch/mips/ar7/memory.c                  |   51 -
>  arch/mips/ar7/platform.c                |  722 -------------
>  arch/mips/ar7/prom.c                    |  256 -----
>  arch/mips/ar7/setup.c                   |   93 --
>  arch/mips/ar7/time.c                    |   31 -
>  arch/mips/boot/compressed/uart-16550.c  |    5 -
>  arch/mips/configs/ar7_defconfig         |  119 ---
>  arch/mips/include/asm/mach-ar7/ar7.h    |  191 ----
>  arch/mips/include/asm/mach-ar7/irq.h    |   16 -
>  arch/mips/include/asm/mach-ar7/prom.h   |   12 -
>  arch/mips/include/asm/mach-ar7/spaces.h |   22 -
>  drivers/Kconfig                         |    2 -
>  drivers/Makefile                        |    1 -
>  drivers/mtd/parsers/Kconfig             |    5 -
>  drivers/mtd/parsers/Makefile            |    1 -
>  drivers/mtd/parsers/ar7part.c           |  129 ---
>  drivers/net/ethernet/ti/Kconfig         |    9 +-
>  drivers/net/ethernet/ti/Makefile        |    1 -
>  drivers/net/ethernet/ti/cpmac.c         | 1251 -----------------------
>  drivers/tty/serial/8250/8250_port.c     |    7 -
>  drivers/vlynq/Kconfig                   |   21 -
>  drivers/vlynq/Makefile                  |    6 -
>  drivers/vlynq/vlynq.c                   |  799 ---------------
>  drivers/watchdog/Kconfig                |    6 -
>  drivers/watchdog/Makefile               |    1 -
>  drivers/watchdog/ar7_wdt.c              |  315 ------
>  include/linux/vlynq.h                   |  149 ---
>  36 files changed, 1 insertion(+), 5209 deletions(-)
>  delete mode 100644 arch/mips/ar7/Makefile
>  delete mode 100644 arch/mips/ar7/Platform
>  delete mode 100644 arch/mips/ar7/clock.c
>  delete mode 100644 arch/mips/ar7/gpio.c
>  delete mode 100644 arch/mips/ar7/irq.c
>  delete mode 100644 arch/mips/ar7/memory.c
>  delete mode 100644 arch/mips/ar7/platform.c
>  delete mode 100644 arch/mips/ar7/prom.c
>  delete mode 100644 arch/mips/ar7/setup.c
>  delete mode 100644 arch/mips/ar7/time.c
>  delete mode 100644 arch/mips/configs/ar7_defconfig
>  delete mode 100644 arch/mips/include/asm/mach-ar7/ar7.h
>  delete mode 100644 arch/mips/include/asm/mach-ar7/irq.h
>  delete mode 100644 arch/mips/include/asm/mach-ar7/prom.h
>  delete mode 100644 arch/mips/include/asm/mach-ar7/spaces.h
>  delete mode 100644 drivers/mtd/parsers/ar7part.c
>  delete mode 100644 drivers/net/ethernet/ti/cpmac.c
>  delete mode 100644 drivers/vlynq/Kconfig
>  delete mode 100644 drivers/vlynq/Makefile
>  delete mode 100644 drivers/vlynq/vlynq.c
>  delete mode 100644 drivers/watchdog/ar7_wdt.c
>  delete mode 100644 include/linux/vlynq.h

applied to mips-next, minus patch 5, which is already applied to net-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/