From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [RFC PATCH v2] mtd: nand: add support for ts72xx
Date: Wed, 4 Oct 2023 10:38:35 +0200 [thread overview]
Message-ID: <20231004103835.55cccdc6@xps-13> (raw)
In-Reply-To: <20231004082223.12762-1-nikita.shubin@maquefel.me>
Hi Nikita,
nikita.shubin@maquefel.me wrote on Wed, 4 Oct 2023 11:22:23 +0300:
> Technologic Systems has it's own nand controller implementation in CPLD.
>
> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> ---
> Changelog v2:
> - dropped check for READCACHE
> - reordered Makefile
>
> Link: https://lore.kernel.org/linux-mtd/20230926132725.5d570e1b@xps-13/T/#md7e5e944a6a08e24f4f1e20068a49f94794ab945
> ---
[...]
> +static int ts72xx_nand_exec_op(struct nand_chip *chip,
> + const struct nand_operation *op, bool check_only)
> +{
> + unsigned int i;
> + int ret;
> +
Missing:
if (check_only)
return 0;
LGTM otherwise.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-10-04 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 8:22 [RFC PATCH v2] mtd: nand: add support for ts72xx Nikita Shubin
2023-10-04 8:38 ` Miquel Raynal [this message]
2023-10-04 8:39 ` Miquel Raynal
2023-10-04 8:50 ` Nikita Shubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004103835.55cccdc6@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nikita.shubin@maquefel.me \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox