public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] mtd: rawnand: add support for TH58NYG3S0HBAI4 NAND flash
Date: Mon, 23 Oct 2023 09:54:51 +0200	[thread overview]
Message-ID: <20231023095451.65c4c0ec@xps-13> (raw)
In-Reply-To: <20231021150212.20509-1-amadeus@jmu.edu.cn>

Hi Chukun,

amadeus@jmu.edu.cn wrote on Sat, 21 Oct 2023 23:02:12 +0800:

> The Toshiba TH58NYG3S0HBAI4 is detected with 128 byte OOB while the flash
> has 256 bytes OOB. This adds a static NAND ID entry to correct this.

Any way you can detect this and fix the parameter page at run time
instead?

> Tested on Arcadyan AW1000 flashed with OpenWrt.
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>  drivers/mtd/nand/raw/nand_ids.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mtd/nand/raw/nand_ids.c b/drivers/mtd/nand/raw/nand_ids.c
> index 650351c62af6..2b871dfd1d09 100644
> --- a/drivers/mtd/nand/raw/nand_ids.c
> +++ b/drivers/mtd/nand/raw/nand_ids.c
> @@ -58,6 +58,9 @@ struct nand_flash_dev nand_flash_ids[] = {
>  		{ .id = {0xad, 0xde, 0x14, 0xa7, 0x42, 0x4a} },
>  		  SZ_16K, SZ_8K, SZ_4M, NAND_NEED_SCRAMBLING, 6, 1664,
>  		  NAND_ECC_INFO(40, SZ_1K) },
> +	{"TH58NYG3S0HBAI4 8G 1.8V 8-bit",
> +		{ .id = {0x98, 0xa3, 0x91, 0x26, 0x76} },
> +		  SZ_4K, SZ_1K, SZ_256K, 0, 4, 256, NAND_ECC_INFO(8, SZ_512) },
>  	{"TH58NVG2S3HBAI4 4G 3.3V 8-bit",
>  		{ .id = {0x98, 0xdc, 0x91, 0x15, 0x76} },
>  		  SZ_2K, SZ_512, SZ_128K, 0, 5, 128, NAND_ECC_INFO(8, SZ_512) },


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2023-10-23  7:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-21 15:02 [PATCH 1/1] mtd: rawnand: add support for TH58NYG3S0HBAI4 NAND flash Chukun Pan
2023-10-23  7:54 ` Miquel Raynal [this message]
2023-10-29  7:20   ` Chukun Pan
2023-10-29 13:48     ` Miquel Raynal
2023-11-14 12:30       ` Chukun Pan
2023-11-15 14:00         ` Chukun Pan
2023-11-16 15:46         ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231023095451.65c4c0ec@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=amadeus@jmu.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox