From: dregan@broadcom.com
To: dregan@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
linux-mtd@lists.infradead.org, f.fainelli@gmail.com,
rafal@milecki.pl, joel.peshkin@broadcom.com,
computersforpeace@gmail.com, dan.beygelman@broadcom.com,
william.zhang@broadcom.com, frieder.schrempf@kontron.de,
linux-kernel@vger.kernel.org, vigneshr@ti.com, richard@nod.at,
bbrezillon@kernel.org, kdasu.kdev@gmail.com,
JaimeLiao <jaimeliao.tw@gmail.com>,
Adam Borowski <kilobyte@angband.pl>
Subject: [PATCH v4 2/4] mtd: rawnand: NAND controller write protect
Date: Mon, 23 Oct 2023 10:14:42 -0700 [thread overview]
Message-ID: <20231023171444.322311-2-dregan@broadcom.com> (raw)
In-Reply-To: <20231023171444.322311-1-dregan@broadcom.com>
From: David Regan <dregan@broadcom.com>
Allow NAND controller to be responsible for write protect pin
handling during fast path and exec_op destructive operation
when controller_wp flag is set.
Signed-off-by: David Regan <dregan@broadcom.com>
---
Changes in v4: none
Changes in v3: update comments
Changes in v2: none
---
drivers/mtd/nand/raw/nand_base.c | 4 ++++
include/linux/mtd/rawnand.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index 47cc2c35153b..38ed0ced5b8e 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -367,6 +367,10 @@ static int nand_check_wp(struct nand_chip *chip)
if (chip->options & NAND_BROKEN_XD)
return 0;
+ /* controller responsible for NAND write protect */
+ if (chip->controller->controller_wp)
+ return 0;
+
/* Check the WP bit */
ret = nand_status_op(chip, &status);
if (ret)
diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
index 31aceda8616c..fcad94aa0515 100644
--- a/include/linux/mtd/rawnand.h
+++ b/include/linux/mtd/rawnand.h
@@ -1111,6 +1111,7 @@ struct nand_controller_ops {
* the bus without restarting an entire read operation nor
* changing the column.
* @supported_op.cont_read: The controller supports sequential cache reads.
+ * @controller_wp: the controller is in charge of handling the WP pin.
*/
struct nand_controller {
struct mutex lock;
@@ -1119,6 +1120,7 @@ struct nand_controller {
unsigned int data_only_read: 1;
unsigned int cont_read: 1;
} supported_op;
+ bool controller_wp;
};
static inline void nand_controller_init(struct nand_controller *nfc)
--
2.37.3
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-10-23 17:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 17:14 [PATCH v4 1/4] mtd: rawnand: Add destructive operation dregan
2023-10-23 17:14 ` dregan [this message]
2023-10-26 0:25 ` [PATCH v4 2/4] mtd: rawnand: NAND controller write protect William Zhang
2023-10-23 17:14 ` [PATCH v4 3/4] mtd: rawnand: brcmnand: pass host struct to bcmnand_ctrl_poll_status dregan
2023-10-26 0:26 ` William Zhang
2023-10-23 17:14 ` [PATCH v4 4/4] mtd: rawnand: brcmnand: exec_op implementation dregan
2023-10-26 0:26 ` William Zhang
2023-11-20 10:28 ` Miquel Raynal
2023-11-21 1:55 ` David Regan
2023-10-26 0:25 ` [PATCH v4 1/4] mtd: rawnand: Add destructive operation William Zhang
2023-11-10 23:10 ` David Regan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023171444.322311-2-dregan@broadcom.com \
--to=dregan@broadcom.com \
--cc=bbrezillon@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=dan.beygelman@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=jaimeliao.tw@gmail.com \
--cc=joel.peshkin@broadcom.com \
--cc=kdasu.kdev@gmail.com \
--cc=kilobyte@angband.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox