From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDA31C00A8F for ; Tue, 24 Oct 2023 15:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oAyey+da64H3E26D3SUI7/9OwJ6UI2yJjz9grY7JGQ0=; b=kWQEpQixfPJ20F HPGtHskVQlSlOseamFQ3y4afFONM6XEaWSzOuKt/mSRlciWck8Ucg4ABtm7mLgcDKQPekln6cSvKr BTHKH8Dgon9LDEQMK9U4dFgLk1Hd89iI5kcs7Hz4Kzulj3i4pc2zehLjqiuRwOJ0xtjAMJThcIPmF XxeS5xh9pMd8UrkdXrrApAvy1dXfjfdgWyxIl2o03zo+NebTnBsbkjoG6KsCloHgtloV/fn1imzEU EIsTyJljffBg+vM/9xy1IG7aY1FKji6aim+8j6+K5LL3mjR9QwiqwsslGUZYRp3a/DXwbnSa0IoUn qpmrZ2D9gtftyxNI8pBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvJmh-00AOsP-12; Tue, 24 Oct 2023 15:57:35 +0000 Received: from mail-ot1-f42.google.com ([209.85.210.42]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvJme-00AOro-2O for linux-mtd@lists.infradead.org; Tue, 24 Oct 2023 15:57:34 +0000 Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-6c7b3adbeb6so3053822a34.0 for ; Tue, 24 Oct 2023 08:57:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698163050; x=1698767850; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NHcRvpJFapb0Q3P+9BlCR7HD1XqDuZe4P3/x1wWBCyM=; b=husSHa3zzGWVAc9ToSp6dn/rLzYNOPtqbVzPx8bzuRZETSffpr74y1LoVV02Atngh6 BAdpHuVLMckTp2EAk/3Ms1g14r5o7Qg0oP2sZKmI9tzVkE4SJ2wArF79i2htlIIZoQpy bK0N+nt6bsB0dx75n4Aforz5OUNBblnzGpfbDERPWDhaOGG7nJs9lp2NHrlUc+oA4awm VzBEvhdmLbE7x5GEIqyNHSv3WOJjkzPDYPd3JUfOFm5W9rynY9PmwkkPlSTrL+GXpJO/ gb7hilJTc3Pg/fMFJFDWgmXpJNR8m17D1PYs6I128jX0swAkWeZ8A+p9xVwSLVhc680f I6Fw== X-Gm-Message-State: AOJu0YzztLhqwKX8iZY9wQR/zu2rfe85tiT9uG0bRaCyxtw+75Hv/r/+ g6fNrJY/cIt/iNWqW4uTjOVBqUYoHw== X-Google-Smtp-Source: AGHT+IGHYmHNXEiTTfwOzmFz01R3ZgSU10kI3zUH744k0D8HWbiWLtUy7kIW318y+4z87Hn4RJxUqA== X-Received: by 2002:a9d:618d:0:b0:6b9:26ce:5e5c with SMTP id g13-20020a9d618d000000b006b926ce5e5cmr13881917otk.31.1698163049764; Tue, 24 Oct 2023 08:57:29 -0700 (PDT) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id f3-20020a4ae603000000b0057b74352e3asm1986286oot.25.2023.10.24.08.57.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 08:57:29 -0700 (PDT) Received: (nullmailer pid 3929057 invoked by uid 1000); Tue, 24 Oct 2023 15:57:28 -0000 Date: Tue, 24 Oct 2023 10:57:28 -0500 From: Rob Herring To: Simon Glass Cc: devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, Miquel Raynal , Michael Walle , U-Boot Mailing List , Tom Rini , Conor Dooley , Dhruva Gole , Krzysztof Kozlowski , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/3] dt-bindings: mtd: partitions: Add binman compatible Message-ID: <20231024155728.GA3707756-robh@kernel.org> References: <20231009220436.2164245-1-sjg@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231009220436.2164245-1-sjg@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231024_085732_800117_23CA8380 X-CRM114-Status: GOOD ( 28.06 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, Oct 09, 2023 at 04:04:13PM -0600, Simon Glass wrote: > Add a compatible string for binman, so we can extend fixed-partitions > in various ways. > > Signed-off-by: Simon Glass > --- > > Changes in v4: > - Change subject line > > Changes in v3: > - Drop fixed-partition additional compatible string > - Drop fixed-partitions from the example > - Mention use of compatible instead of label > > Changes in v2: > - Drop mention of 'enhanced features' in fixed-partitions.yaml > - Mention Binman input and output properties > - Use plain partition@xxx for the node name > > .../bindings/mtd/partitions/binman.yaml | 63 +++++++++++++++++++ > .../bindings/mtd/partitions/partitions.yaml | 1 + > MAINTAINERS | 5 ++ > 3 files changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/partitions/binman.yaml > > diff --git a/Documentation/devicetree/bindings/mtd/partitions/binman.yaml b/Documentation/devicetree/bindings/mtd/partitions/binman.yaml > new file mode 100644 > index 000000000000..7d6c8bd738f5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/partitions/binman.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2023 Google LLC > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/partitions/binman.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Binman firmware layout > + > +maintainers: > + - Simon Glass > + > +select: false > + > +description: | > + The binman node provides a layout for firmware, used when packaging firmware > + from multiple projects. It is based on fixed-partitions, with some > + extensions, but uses 'compatible' to indicate the contents of the node, to > + avoid perturbing or confusing existing installations which use 'label' for a > + particular purpose. > + > + Binman supports properties used as inputs to the firmware-packaging process, > + such as those which control alignment of partitions. This binding addresses > + these 'input' properties. For example, it is common for the 'reg' property > + (an 'output' property) to be set by Binman, based on the alignment requested > + in the input. > + > + Once processing is complete, input properties have mostly served their > + purpose, at least until the firmware is repacked later, e.g. due to a > + firmware update. The 'fixed-partitions' binding should provide enough > + information to read the firmware at runtime, including decompression if > + needed. > + > + Documentation for Binman is available at: > + > + https://u-boot.readthedocs.io/en/latest/develop/package/binman.html > + > + with the current image-description format at: > + > + https://u-boot.readthedocs.io/en/latest/develop/package/binman.html#image-description-format > + > +allOf: > + - $ref: /schemas/mtd/partitions/fixed-partitions.yaml# > + > +properties: > + compatible: > + const: binman This couldn't possibly pass validation. Including fixed-partitions.yaml says the compatible must be one thing and this says something else. > + > +additionalProperties: false > + > +examples: > + - | > + partitions { > + compatible = "binman"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + partition@100000 { > + label = "u-boot"; > + reg = <0x100000 0xf00000>; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml b/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml > index 1dda2c80747b..849fd15d085c 100644 > --- a/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml > +++ b/Documentation/devicetree/bindings/mtd/partitions/partitions.yaml > @@ -15,6 +15,7 @@ maintainers: > > oneOf: > - $ref: arm,arm-firmware-suite.yaml > + - $ref: binman.yaml > - $ref: brcm,bcm4908-partitions.yaml > - $ref: brcm,bcm947xx-cfe-partitions.yaml > - $ref: fixed-partitions.yaml > diff --git a/MAINTAINERS b/MAINTAINERS > index c934244acc31..ebc8158fe67d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3536,6 +3536,11 @@ F: Documentation/filesystems/bfs.rst > F: fs/bfs/ > F: include/uapi/linux/bfs_fs.h > > +BINMAN > +M: Simon Glass > +S: Supported > +F: Documentation/devicetree/bindings/mtd/partitions/binman* > + > BITMAP API > M: Yury Norov > R: Andy Shevchenko > -- > 2.42.0.609.gbb76f46606-goog > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/