Re: [PATCH 1/1] mtd: rawnand: add support for TH58NYG3S0HBAI4 NAND flash

Miquel Raynal
2023-11-16T15:46:59Z

Hi Chukun,

amadeus@jmu.edu.cn wrote on Tue, 14 Nov 2023 20:30:08 +0800:

> Hi Miquel,
>
> > It's more like a request than a question. Please fix the parameter page
> > at run time by registering a ->.fixup_onfi_param_page() hook in
> > Toshiba's nand_manufacturer_ops structure.
>
> Sorry for the late reply. This flash is not ONFI compliant NAND,
> so onfi fixup can't work. Datasheet available at:
> https://europe.kioxia.com/content/dam/kioxia/newidr/productinfo/datasheet/201910/DST_TH58NYG3S0HBAI4-TDE_EN_31565.pdf

You said in your commit log that this flash was detected with a smaller
(or bigger, I don't remember) OOB size than it really has. This number
comes from somewhere? Is it an existing ID? Is it an auto-discovery
mechanism?

If it's an ID then why not adding a new entry. Otherwise you can I
guess make some changes in the device geometry in the manufacturer init
operation as well if the fixup-onfi hook does no apply.

Thanks,
Miquèl