From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yuta Hayama <hayama@lineo.co.jp>
Cc: stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
Claire Lin <claire.lin@broadcom.com>,
Ray Jui <ray.jui@broadcom.com>, Kamal Dasu <kdasu.kdev@gmail.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 4.14] mtd: rawnand: brcmnand: Fix ecc chunk calculation for erased page bitfips
Date: Thu, 30 Nov 2023 13:42:27 +0000 [thread overview]
Message-ID: <2023113017-dictator-rotting-6bbe@gregkh> (raw)
In-Reply-To: <1dfa7e7f-233b-43da-b0ea-0ad3b1f69a37@lineo.co.jp>
On Wed, Nov 29, 2023 at 05:29:13PM +0900, Yuta Hayama wrote:
> From: Claire Lin <claire.lin@broadcom.com>
>
> commit 7f852cc1579297fd763789f8cd370639d0c654b6 upstream.
>
> In brcmstb_nand_verify_erased_page(), the ECC chunk pointer calculation
> while correcting erased page bitflips is wrong, fix it.
>
> Fixes: 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflips")
> Signed-off-by: Claire Lin <claire.lin@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Yuta Hayama <hayama@lineo.co.jp>
> ---
> After applying e44b9a9c1357 ("mtd: nand: brcmnand: Zero bitflip is not an
> error"), the return value 0 of brcmstb_nand_verify_erased_page() is
> *correctly* interpreted as "no bit flips, no errors". However, that
> function still has the issue that it may incorrectly return 0 for a page
> that contains bitflips. Without this patch, the data buffer of the erased
> page could be passed to a upper layer (e.g. UBIFS) without bitflips being
> detected and corrected.
>
> In active stable, 4.14.y and 4.19.y seem to have a same issue.
Both now queued up, thanks.
greg k-h
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2023-11-30 13:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 8:29 [PATCH 4.14] mtd: rawnand: brcmnand: Fix ecc chunk calculation for erased page bitfips Yuta Hayama
2023-11-30 13:42 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023113017-dictator-rotting-6bbe@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=claire.lin@broadcom.com \
--cc=hayama@lineo.co.jp \
--cc=kdasu.kdev@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=ray.jui@broadcom.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox