From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
Christophe Kerello <christophe.kerello@foss.st.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
Johan Jonker <jbx6244@gmail.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v6 20/40] mtd: rawnand: add support for ts72xx
Date: Tue, 12 Dec 2023 15:05:45 +0100 [thread overview]
Message-ID: <20231212150545.61806147@xps-13> (raw)
In-Reply-To: <29970d694d155dee0c76612f453eaa06a929e2c1.camel@maquefel.me>
Hello,
nikita.shubin@maquefel.me wrote on Tue, 12 Dec 2023 11:35:48 +0300:
> Hello Greg!
>
> On Tue, 2023-12-12 at 09:30 +0100, Greg Kroah-Hartman wrote:
> > On Tue, Dec 12, 2023 at 11:20:37AM +0300, Nikita Shubin via B4 Relay
> > wrote:
> > > From: Nikita Shubin <nikita.shubin@maquefel.me>
> > >
> > > Technologic Systems has it's own nand controller implementation in
> > > CPLD.
> > >
> > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> > > ---
> > > drivers/mtd/nand/raw/Kconfig | 7 +
> > > drivers/mtd/nand/raw/Makefile | 1 +
> > > drivers/mtd/nand/raw/technologic-nand-controller.c | 220
> > > +++++++++++++++++++++
> > > 3 files changed, 228 insertions(+)
> > >
> > > diff --git a/drivers/mtd/nand/raw/Kconfig
> > > b/drivers/mtd/nand/raw/Kconfig
> > > index cbf8ae85e1ae..3937c10dea1c 100644
> > > --- a/drivers/mtd/nand/raw/Kconfig
> > > +++ b/drivers/mtd/nand/raw/Kconfig
> > > @@ -449,6 +449,13 @@ config MTD_NAND_RENESAS
> > > Enables support for the NAND controller found on Renesas
> > > R-Car
> > > Gen3 and RZ/N1 SoC families.
> > >
> > > +config MTD_NAND_TS72XX
> > > + tristate "ts72xx NAND controller"
> > > + depends on ARCH_EP93XX && HAS_IOMEM
> > > + help
> > > + Enables support for NAND controller on ts72xx SBCs.
> > > + This is a legacy driver based on gen_nand.
> >
> > Why is a new "legacy driver" being written these days? Why not do it
> > properly?
>
> Sorry, my bad, description is a leftover from older description (when i
> was allowed to submit a legacy one).
>
> The driver is mostly new, shiny and approved by Miquel:
>
> https://lore.kernel.org/lkml/20231004103911.2aa65354@xps-13/
>
> The KConfig description should be fixed.
Indeed, later submissions carried a brand new implementation which no
longer leverages any legacy hook. The Kconfig description is wrong,
good catch.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-12-12 14:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 8:20 [PATCH v6 00/40] ep93xx device tree conversion Nikita Shubin via B4 Relay
2023-12-12 8:20 ` [PATCH v6 19/40] dt-bindings: mtd: Add ts7200 nand-controller Nikita Shubin via B4 Relay
2023-12-12 8:20 ` [PATCH v6 20/40] mtd: rawnand: add support for ts72xx Nikita Shubin via B4 Relay
2023-12-12 8:30 ` Greg Kroah-Hartman
2023-12-12 8:35 ` Nikita Shubin
2023-12-12 14:05 ` Miquel Raynal [this message]
2023-12-15 10:16 ` Miquel Raynal
2023-12-15 12:11 ` Nikita Shubin
2023-12-15 12:27 ` Miquel Raynal
2023-12-12 11:53 ` [PATCH v6 00/40] ep93xx device tree conversion Uwe Kleine-König
2023-12-13 17:59 ` Andy Shevchenko
2023-12-23 9:12 ` Nikita Shubin
2023-12-25 19:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212150545.61806147@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=arnd@arndb.de \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=christophe.kerello@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbx6244@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=nikita.shubin@maquefel.me \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox