From: David Regan <dregan@broadcom.com>
To: dregan@broadcom.com, dregan@mail.com, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
computersforpeace@gmail.com, kdasu.kdev@gmail.com,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, joel.peshkin@broadcom.com,
tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com,
william.zhang@broadcom.com, anand.gore@broadcom.com,
kursad.oney@broadcom.com, florian.fainelli@broadcom.com,
rafal@milecki.pl, bcm-kernel-feedback-list@broadcom.com,
andre.przywara@arm.com, baruch@tkos.co.il,
linux-arm-kernel@lists.infradead.org, dan.carpenter@linaro.org
Subject: [PATCH v3 07/10] mtd: rawnand: brcmnand: Support write protection setting from dts
Date: Tue, 23 Jan 2024 19:04:55 -0800 [thread overview]
Message-ID: <20240124030458.98408-8-dregan@broadcom.com> (raw)
In-Reply-To: <20240124030458.98408-1-dregan@broadcom.com>
From: William Zhang <william.zhang@broadcom.com>
The write protection feature is controlled by the module parameter wp_on
with default set to enabled. But not all the board use this feature
especially in BCMBCA broadband board. And module parameter is not
sufficient as different board can have different option. Add a device
tree property and allow this feature to be configured through the board
dts on per board basis.
Signed-off-by: William Zhang <william.zhang@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Kamal Dasu <kamal.dasu@broadcom.com>
Reviewed-by: David Regan <dregan@broadcom.com>
---
Changes in v3: None
---
Changes in v2: None
---
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index 869ea64e9189..9a904c7c6dad 100644
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -3081,7 +3081,7 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
struct brcmnand_controller *ctrl;
struct brcmnand_host *host;
struct resource *res;
- int ret;
+ int ret, wp_dt;
if (dn && !of_match_node(brcmnand_of_match, dn))
return -ENODEV;
@@ -3218,6 +3218,12 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
/* Disable XOR addressing */
brcmnand_rmw_reg(ctrl, BRCMNAND_CS_XOR, 0xff, 0, 0);
+ /* Not all boards support write protect (WP), check DT property */
+ if (of_property_read_u32(dn, "brcm,nand-use-wp", &wp_dt) == 0) {
+ if (wp_dt >= 0 && wp_dt <= 2)
+ wp_on = wp_dt;
+ }
+
if (ctrl->features & BRCMNAND_HAS_WP) {
/* Permanently disable write protection */
if (wp_on == 2)
--
2.37.3
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2024-01-24 3:07 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 3:04 [PATCH v3 00/10] mtd: rawnand: brcmnand: driver and doc updates David Regan
2024-01-24 3:04 ` [PATCH v3 01/10] dt-bindings: mtd: brcmnand: Updates for bcmbca SoCs David Regan
2024-01-24 17:24 ` Conor Dooley
2024-01-25 3:01 ` William Zhang
2024-01-25 19:51 ` Conor Dooley
2024-01-26 1:55 ` William Zhang
2024-01-26 16:46 ` Conor Dooley
2024-01-26 18:09 ` William Zhang
2024-01-24 17:24 ` Conor Dooley
2024-01-24 17:34 ` Miquel Raynal
2024-01-25 3:14 ` William Zhang
2024-01-24 3:04 ` [PATCH v3 02/10] ARM: dts: broadcom: bcmbca: Add NAND controller node David Regan
2024-01-24 17:30 ` Miquel Raynal
2024-01-25 3:09 ` William Zhang
2024-01-25 3:34 ` Florian Fainelli
2024-01-25 5:53 ` William Zhang
2024-01-25 9:20 ` Miquel Raynal
2024-01-25 18:14 ` William Zhang
2024-01-24 3:04 ` [PATCH v3 03/10] arm64: " David Regan
2024-01-24 3:04 ` [PATCH v3 04/10] mtd: rawnand: brcmnand: Rename bcm63138 nand driver David Regan
2024-01-24 3:04 ` [PATCH v3 05/10] mtd: rawnand: brcmnand: Add BCMBCA read data bus interface David Regan
2024-01-24 3:04 ` [PATCH v3 06/10] mtd: rawnand: brcmnand: Add support for getting ecc setting from strap David Regan
2024-01-24 17:32 ` Miquel Raynal
2024-01-25 3:13 ` William Zhang
2024-01-24 3:04 ` David Regan [this message]
2024-01-24 3:04 ` [PATCH v3 08/10] mtd: rawnand: brcmnand: exec_op helper functions return type fixes David Regan
2024-01-24 17:35 ` Miquel Raynal
2024-01-24 3:04 ` [PATCH v3 09/10] mtd: rawnand: brcmnand: update log level messages David Regan
2024-01-24 17:37 ` Miquel Raynal
2024-01-25 18:47 ` David Regan
2024-01-24 3:04 ` [PATCH v3 10/10] mtd: rawnand: brcmnand: allow for on-die ecc David Regan
2024-01-24 17:40 ` Miquel Raynal
2024-01-25 19:47 ` David Regan
2024-01-26 6:19 ` Miquel Raynal
2024-01-26 19:57 ` David Regan
2024-01-29 10:52 ` Miquel Raynal
2024-01-30 8:11 ` William Zhang
2024-01-30 11:01 ` Miquel Raynal
2024-01-30 15:26 ` David Regan
2024-01-30 18:55 ` Miquel Raynal
2024-02-01 6:48 ` William Zhang
2024-02-01 8:25 ` Miquel Raynal
2024-02-01 18:53 ` William Zhang
2024-02-02 17:38 ` David Regan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124030458.98408-8-dregan@broadcom.com \
--to=dregan@broadcom.com \
--cc=anand.gore@broadcom.com \
--cc=andre.przywara@arm.com \
--cc=baruch@tkos.co.il \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=conor+dt@kernel.org \
--cc=dan.beygelman@broadcom.com \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dregan@mail.com \
--cc=florian.fainelli@broadcom.com \
--cc=joel.peshkin@broadcom.com \
--cc=kdasu.kdev@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=tomer.yacoby@broadcom.com \
--cc=vigneshr@ti.com \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox