public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Michael Pratt <mcpratt@pm.me>
Cc: devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	saravanak@google.com, abel.vesa@linaro.org,
	alexander.stein@ew.tq-group.com,
	andriy.shevchenko@linux.intel.com, bigunclemax@gmail.com,
	brgl@bgdev.pl, colin.foster@in-advantage.com,
	djrscally@gmail.com, dmitry.baryshkov@linaro.org,
	festevam@gmail.com, fido_max@inbox.ru, frowand.list@gmail.com,
	geert@linux-m68k.org, heikki.krogerus@linux.intel.com,
	kernel@pengutronix.de, linus.walleij@linaro.org,
	linux@roeck-us.net, luca.weiss@fairphone.com,
	magnus.damm@gmail.com, martin.kepplinger@puri.sm,
	rafal@milecki.pl, ansuelsmth@gmail.com, richard@nod.at,
	sakari.ailus@linux.intel.com, sudeep.holla@arm.com,
	tglx@linutronix.de, tony@atomide.com, vigneshr@ti.com,
	dianders@chromium.org, jpb@kernel.org, rafael@kernel.org
Subject: Re: [PATCH v1 4/4] mtd: mtdpart: Allow fwnode links to NVMEM compatible fwnodes
Date: Mon, 5 Feb 2024 16:11:29 +0100	[thread overview]
Message-ID: <20240205161129.1889a943@xps-13> (raw)
In-Reply-To: <20240123014517.5787-5-mcpratt@pm.me>

Hi Michael,

mcpratt@pm.me wrote on Tue, 23 Jan 2024 01:47:21 +0000:

> This reverts commit fb42378dcc7f247df56f0ecddfdae85487495fbc
> ("mtd: mtdpart: Don't create platform device that'll never probe").
> 
> That commit is a manual named exception in order to avoid fw_devlink links
> to an "nvmem-cells" compatible node which is a descendant of the fwnode
> that represents the real supplier device that probes.
> 
> The commit does not work for newer cases, like the "fixed-layout"

Do you have plans for it? Because it is the modern description that is
now expected, so I don't feel convinced by all this work (which is
nevertheless considerable) if fixed-layouts are still broken?

> compatible nodes, but instead of adding another compatible string,
> remove this workaround as it is no longer needed after
> the previous few commits which handle the situation in a generic way
> for all supplier nodes that are a child or further descendant fwnode
> of a parent device that can probe, including when the consumer device
> has a probe attempt before the supplier device, by using an existing
> incorrect fwnode or device link to recreate the correct one.
> 
> Signed-off-by: Michael Pratt <mcpratt@pm.me>

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2024-02-05 15:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23  1:45 [PATCH v1 0/4] fw_devlink: generically handle bad links to child fwnodes Michael Pratt
2024-01-23  1:46 ` [PATCH v1 1/4] driver core: fw_devlink: Use driver to determine probe ability Michael Pratt
2024-02-14  3:18   ` Saravana Kannan
2024-01-23  1:46 ` [PATCH v1 2/4] driver core: fw_devlink: Link to supplier ancestor if no device Michael Pratt
2024-02-05 15:00   ` Miquel Raynal
2024-02-25 20:16     ` Michael Pratt
2024-02-05 19:25   ` Saravana Kannan
2024-02-14  3:18     ` Saravana Kannan
2024-02-25 20:37     ` Michael Pratt
2024-01-23  1:47 ` [PATCH v1 3/4] driver core: fw_devlink: Add function device_links_fixup_suppliers() Michael Pratt
2024-01-23  1:47 ` [PATCH v1 4/4] mtd: mtdpart: Allow fwnode links to NVMEM compatible fwnodes Michael Pratt
2024-02-05 15:11   ` Miquel Raynal [this message]
2024-02-25 17:35     ` Michael Pratt
2024-02-05 20:06 ` [PATCH v1 0/4] fw_devlink: generically handle bad links to child fwnodes Saravana Kannan
2024-02-14  3:28   ` Saravana Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240205161129.1889a943@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=abel.vesa@linaro.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ansuelsmth@gmail.com \
    --cc=bigunclemax@gmail.com \
    --cc=brgl@bgdev.pl \
    --cc=colin.foster@in-advantage.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=djrscally@gmail.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=festevam@gmail.com \
    --cc=fido_max@inbox.ru \
    --cc=frowand.list@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jpb@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=luca.weiss@fairphone.com \
    --cc=magnus.damm@gmail.com \
    --cc=martin.kepplinger@puri.sm \
    --cc=mcpratt@pm.me \
    --cc=rafael@kernel.org \
    --cc=rafal@milecki.pl \
    --cc=richard@nod.at \
    --cc=sakari.ailus@linux.intel.com \
    --cc=saravanak@google.com \
    --cc=sudeep.holla@arm.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox