Re: [PATCH] mtd: spi-nor: Add support for BoHong bh25q128as

Michael Walle
2021-05-10T09:51:47Z

Hi David,

Am 2021-05-10 11:28, schrieb David Bauer:
> On 5/10/21 10:00 AM, Michael Walle wrote
>
> [...]
>
>>> +static const struct flash_info bohong_parts[] = {
>>> +    /* BoHong Microelectronics */
>>> +    { "bh25q128as", INFO(0x684018, 0, 64 * 1024, 256,
>>
>> I couldn't find "BoHong" in JEP106BC. 0x68 (without continuation
>> codes)
>> is "Convex Computer". So this is wrong. OTOH I'm not sure, how many
>> SPI flashes "convex computer" have, if any ;) This company was brought
>> by HP in the end.
>>
>> In any case, this patch depends on how we handle continuation codes or
>> if we can handle them at all. Or if this flash just lie about its
>> manufacturer id and don't and CC.
>
> First of all, BoHong and Boya microelectronics seems to be the same
> company, as their datasheets seem to copy each other. There's not much
> information about either of both, so I'd say that's a fair assumption.
>
> Regarding the continuation codes, Boya is listed in bank nine, however
> in this case I should currently read an all 0x7f ID shouldn't I?

I'd guess so, yes.

> The datasheet also only specifies 3 bytes as a return value for
> register 0x9fh :(

Yeah. So, this flash falls into the same category "simply hijacks
a manuf id" as all the other flashes.

We still need to come up with a solution for this problem.

-michael