Re: [PATCH] mtd: rawnand: hynix: fixed typo

Miquel Raynal
2024-03-15T11:23:22Z

Hi Maxim,

korotkov.maxim.s@gmail.com wrote on Wed, 13 Mar 2024 13:27:20 +0300:

> The function hynix_nand_rr_init() should probably return an error code.
> Judging by the usage, it seems that the return code is passed up
> the call stack.
> Right now, it always returns 0 and the function hynix_nand_cleanup()
> in hynix_nand_init() has never been called.

Isn't it done like that on purpose? Read-retry is not a mandatory
feature.

> Found by RASU JSC and Linux Verification Center (linuxtesting.org)
>
> Fixes: 626994e07480 ("mtd: nand: hynix: Add read-retry support for 1x nm MLC NANDs")
>
> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
> ---

Thanks,
Miquèl