Re: [PATCH v6 5/8] drivers: mtd: nand: use FIELD_PREP and GENMASK

Md Sadre Alam
2024-05-22T06:09:45Z

On 5/21/2024 6:23 PM, Miquel Raynal wrote:
> Hi,
>
> quic_mdalam@quicinc.com wrote on Tue, 21 May 2024 16:25:29 +0530:
>
>> Use the bitfield macro FIELD_PREP, and GENMASK to
>> do the shift and mask in one go. This makes the code
>> more readable.
>>
>> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
>> ---
>> Change in [v6]
>>
>> * Added FIELD_PREP() and GENMASK() macro
>
> Maybe you want to include linux/bitfield.h now.
Ok
>
> Otherwise that's a great improvement.
>
> Thanks,
> Miquèl