From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Pratyush Yadav <pratyush@kernel.org>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Michael Walle <michael@walle.cc>, <linux-mtd@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
<linux-arm-kernel@lists.infradead.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH next 2/2] mtd: rawnand: mtk: Fix init error path
Date: Wed, 4 Sep 2024 16:25:15 +0200 [thread overview]
Message-ID: <20240904162515.2af2415d@xps-13> (raw)
In-Reply-To: <mafs05xrbika8.fsf@kernel.org>
Hi Pratyush,
pratyush@kernel.org wrote on Wed, 04 Sep 2024 16:08:15 +0200:
> On Mon, Aug 26 2024, Miquel Raynal wrote:
>
> > Reviewing a series converting the for_each_chil_of_node() loops into
> > their _scoped variants made me realize there was no cleanup of the
> > already registered NAND devices upon error which may leak memory on
> > systems with more than a chip when this error occurs. We should call the
> > _nand_chips_cleanup() function when this happens.
> >
> > Fixes: Fixes: 1d6b1e464950 ("mtd: mediatek: driver for MTK Smart Device")
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
> Did a quick scan. Can't see anything (obvious) else being leaked on
> error paths.
Great! Thanks a lot for the reviews!
> Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
Cheers,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2024-09-04 14:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 15:30 [PATCH next 1/2] mtd: rawnand: mtk: Factorize out the logic cleaning mtk chips Miquel Raynal
2024-08-26 15:30 ` [PATCH next 2/2] mtd: rawnand: mtk: Fix init error path Miquel Raynal
2024-09-04 14:08 ` Pratyush Yadav
2024-09-04 14:25 ` Miquel Raynal [this message]
2024-09-06 15:01 ` Matthias Brugger
2024-09-06 15:02 ` Miquel Raynal
2024-09-04 14:15 ` [PATCH next 1/2] mtd: rawnand: mtk: Factorize out the logic cleaning mtk chips Pratyush Yadav
2024-09-06 15:01 ` Matthias Brugger
2024-09-06 15:02 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904162515.2af2415d@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=michael@walle.cc \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox