Re: [PATCH v9 6/6] mtd: spi-nor: add support for Macronix Octal flash

Michael Walle
2024-09-23T07:18:21Z

Hi,

> > --- a/drivers/mtd/spi-nor/macronix.c
> > +++ b/drivers/mtd/spi-nor/macronix.c
> > @@ -200,7 +200,9 @@ static const struct flash_info macronix_nor_parts[] = {
> > .name = "mx25l3255e",
> > .size = SZ_4M,
> > .no_sfdp_flags = SECT_4K,
> > - }
> > + },
> > + /* Need the manufacturer fixups, Keep this last */
> > + { .id = SNOR_ID(0xc2) }
> > };
> >
>
> Could you please elaborate why you need just the manufacturer id here? I
> would have expected to see a specific flash entry instead.

I can't find the thread anymore as this is going on for forever, but
that was my suggestion. That's a catch all to have the manufacturer
fixup applied for any macronix flashes instead of having to list
each flash id here.

-michael