Re: [PATCH v9 6/6] mtd: spi-nor: add support for Macronix Octal flash

Tudor Ambarus
2024-09-24T06:31:23Z

On 9/24/24 4:25 AM, Alvin Zhou wrote:
> Hi Tudor,
>
> Tudor Ambarus <tudor.ambarus@linaro.org> 於 2024年9月23日 週一 下午2:54寫道：
>>
>> Hi, Alvin,
>>
>> I quickly skimmed over the previous 5 patches and they are looking fine.
>>
>> I don't get this patch however.
>>
>> On 7/18/24 4:46 AM, AlvinZhou wrote:
>>> From: AlvinZhou <alvinzhou@mxic.com.tw>
>>>
>>> Adding Manufacture ID 0xC2 in last of ID table because of
>>> Octal Flash need manufacturer fixup for enabling/disabling
>>> Octal DTR mode.
>>>
>>> Signed-off-by: JaimeLiao <jaimeliao@mxic.com.tw>
>>> Signed-off-by: AlvinZhou <alvinzhou@mxic.com.tw>
>>> ---
>>> drivers/mtd/spi-nor/macronix.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
>>> index f039819a5252..1a8ccebdfe0e 100644
>>> --- a/drivers/mtd/spi-nor/macronix.c
>>> +++ b/drivers/mtd/spi-nor/macronix.c
>>> @@ -200,7 +200,9 @@ static const struct flash_info macronix_nor_parts[] = {
>>> .name = "mx25l3255e",
>>> .size = SZ_4M,
>>> .no_sfdp_flags = SECT_4K,
>>> - }
>>> + },
>>> + /* Need the manufacturer fixups, Keep this last */
>>> + { .id = SNOR_ID(0xc2) }
>>> };
>>>
>>
>> Could you please elaborate why you need just the manufacturer id here? I
>> would have expected to see a specific flash entry instead.
>
> Grateful to Michael for the valuable suggestion. This addition of the
> Macronix manufacturer ID enables the fixup functions such as
> macronix_nor_set_octal_dtr to be executed without the need to
> create separate ID entries for each Octal DTR NOR Flash in the
> flash_info.
>

Ah, nice. Okay then. I'm going to review the rest of the patches. They
look promising ;).