* [PATCH] mtd: hyperbus: rpc-if: Add missing MODULE_DEVICE_TABLE
@ 2024-07-31 8:08 Biju Das
2024-07-31 8:28 ` Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Biju Das @ 2024-07-31 8:08 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger
Cc: Biju Das, Vignesh Raghavendra, Tudor Ambarus, Sergei Shtylyov,
linux-mtd, Geert Uytterhoeven, Prabhakar Mahadev Lad, Biju Das,
linux-renesas-soc
The rpc-if-hyperflash driver can be compiled as a module, but lacks
MODULE_DEVICE_TABLE() and will therefore not be loaded automatically.
Fix this.
Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver")
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
Note:
Only compile tested. Changes are similar to [1]
[1] https://lore.kernel.org/all/20240731072955.224125-1-biju.das.jz@bp.renesas.com/
---
drivers/mtd/hyperbus/rpc-if.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/mtd/hyperbus/rpc-if.c b/drivers/mtd/hyperbus/rpc-if.c
index b22aa57119f2..e7a28f3316c3 100644
--- a/drivers/mtd/hyperbus/rpc-if.c
+++ b/drivers/mtd/hyperbus/rpc-if.c
@@ -163,9 +163,16 @@ static void rpcif_hb_remove(struct platform_device *pdev)
pm_runtime_disable(hyperbus->rpc.dev);
}
+static const struct platform_device_id rpc_if_hyperflash_id_table[] = {
+ { .name = "rpc-if-hyperflash" },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(platform, rpc_if_hyperflash_id_table);
+
static struct platform_driver rpcif_platform_driver = {
.probe = rpcif_hb_probe,
.remove_new = rpcif_hb_remove,
+ .id_table = rpc_if_hyperflash_id_table,
.driver = {
.name = "rpc-if-hyperflash",
},
--
2.43.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: hyperbus: rpc-if: Add missing MODULE_DEVICE_TABLE
2024-07-31 8:08 [PATCH] mtd: hyperbus: rpc-if: Add missing MODULE_DEVICE_TABLE Biju Das
@ 2024-07-31 8:28 ` Geert Uytterhoeven
2024-08-06 17:16 ` Vignesh Raghavendra
2024-08-23 17:31 ` Miquel Raynal
2 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2024-07-31 8:28 UTC (permalink / raw)
To: Biju Das
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Tudor Ambarus, Sergei Shtylyov, linux-mtd, Geert Uytterhoeven,
Prabhakar Mahadev Lad, Biju Das, linux-renesas-soc
On Wed, Jul 31, 2024 at 10:08 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> The rpc-if-hyperflash driver can be compiled as a module, but lacks
> MODULE_DEVICE_TABLE() and will therefore not be loaded automatically.
> Fix this.
>
> Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: hyperbus: rpc-if: Add missing MODULE_DEVICE_TABLE
2024-07-31 8:08 [PATCH] mtd: hyperbus: rpc-if: Add missing MODULE_DEVICE_TABLE Biju Das
2024-07-31 8:28 ` Geert Uytterhoeven
@ 2024-08-06 17:16 ` Vignesh Raghavendra
2024-08-23 17:31 ` Miquel Raynal
2 siblings, 0 replies; 6+ messages in thread
From: Vignesh Raghavendra @ 2024-08-06 17:16 UTC (permalink / raw)
To: Biju Das, Miquel Raynal, Richard Weinberger
Cc: Tudor Ambarus, Sergei Shtylyov, linux-mtd, Geert Uytterhoeven,
Prabhakar Mahadev Lad, Biju Das, linux-renesas-soc
On 31/07/24 13:38, Biju Das wrote:
> The rpc-if-hyperflash driver can be compiled as a module, but lacks
> MODULE_DEVICE_TABLE() and will therefore not be loaded automatically.
> Fix this.
>
> Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
> Note:
> Only compile tested. Changes are similar to [1]
> [1] https://lore.kernel.org/all/20240731072955.224125-1-biju.das.jz@bp.renesas.com/
> ---
> drivers/mtd/hyperbus/rpc-if.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/mtd/hyperbus/rpc-if.c b/drivers/mtd/hyperbus/rpc-if.c
> index b22aa57119f2..e7a28f3316c3 100644
> --- a/drivers/mtd/hyperbus/rpc-if.c
> +++ b/drivers/mtd/hyperbus/rpc-if.c
> @@ -163,9 +163,16 @@ static void rpcif_hb_remove(struct platform_device *pdev)
> pm_runtime_disable(hyperbus->rpc.dev);
> }
>
> +static const struct platform_device_id rpc_if_hyperflash_id_table[] = {
> + { .name = "rpc-if-hyperflash" },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(platform, rpc_if_hyperflash_id_table);
> +
> static struct platform_driver rpcif_platform_driver = {
> .probe = rpcif_hb_probe,
> .remove_new = rpcif_hb_remove,
> + .id_table = rpc_if_hyperflash_id_table,
> .driver = {
> .name = "rpc-if-hyperflash",
> },
--
Regards
Vignesh
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: hyperbus: rpc-if: Add missing MODULE_DEVICE_TABLE
2024-07-31 8:08 [PATCH] mtd: hyperbus: rpc-if: Add missing MODULE_DEVICE_TABLE Biju Das
2024-07-31 8:28 ` Geert Uytterhoeven
2024-08-06 17:16 ` Vignesh Raghavendra
@ 2024-08-23 17:31 ` Miquel Raynal
2024-10-21 9:15 ` Miquel Raynal
2 siblings, 1 reply; 6+ messages in thread
From: Miquel Raynal @ 2024-08-23 17:31 UTC (permalink / raw)
To: Biju Das, Miquel Raynal, Richard Weinberger
Cc: Vignesh Raghavendra, Tudor Ambarus, Sergei Shtylyov, linux-mtd,
Geert Uytterhoeven, Prabhakar Mahadev Lad, Biju Das,
linux-renesas-soc
On Wed, 2024-07-31 at 08:08:40 UTC, Biju Das wrote:
> The rpc-if-hyperflash driver can be compiled as a module, but lacks
> MODULE_DEVICE_TABLE() and will therefore not be loaded automatically.
> Fix this.
>
> Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: hyperbus: rpc-if: Add missing MODULE_DEVICE_TABLE
2024-08-23 17:31 ` Miquel Raynal
@ 2024-10-21 9:15 ` Miquel Raynal
2024-10-21 9:20 ` Biju Das
0 siblings, 1 reply; 6+ messages in thread
From: Miquel Raynal @ 2024-10-21 9:15 UTC (permalink / raw)
To: Biju Das, Miquel Raynal, Richard Weinberger
Cc: Vignesh Raghavendra, Tudor Ambarus, Sergei Shtylyov, linux-mtd,
Geert Uytterhoeven, Prabhakar Mahadev Lad, Biju Das,
linux-renesas-soc
miquel.raynal@bootlin.com wrote on Fri, 23 Aug 2024 19:31:43 +0200:
> On Wed, 2024-07-31 at 08:08:40 UTC, Biju Das wrote:
> > The rpc-if-hyperflash driver can be compiled as a module, but lacks
> > MODULE_DEVICE_TABLE() and will therefore not be loaded automatically.
> > Fix this.
> >
> > Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver")
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
>
> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.
I just realize now this patch got applied but not included in any final
PR, sorry about that, I'll handle it.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] mtd: hyperbus: rpc-if: Add missing MODULE_DEVICE_TABLE
2024-10-21 9:15 ` Miquel Raynal
@ 2024-10-21 9:20 ` Biju Das
0 siblings, 0 replies; 6+ messages in thread
From: Biju Das @ 2024-10-21 9:20 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger
Cc: Vignesh Raghavendra, Tudor Ambarus, Sergei Shtylyov,
linux-mtd@lists.infradead.org, Geert Uytterhoeven,
Prabhakar Mahadev Lad, biju.das.au,
linux-renesas-soc@vger.kernel.org
Hi Miquel Raynal,
> -----Original Message-----
> From: Miquel Raynal <miquel.raynal@bootlin.com>
> Sent: Monday, October 21, 2024 10:15 AM
> Subject: Re: [PATCH] mtd: hyperbus: rpc-if: Add missing MODULE_DEVICE_TABLE
>
>
> miquel.raynal@bootlin.com wrote on Fri, 23 Aug 2024 19:31:43 +0200:
>
> > On Wed, 2024-07-31 at 08:08:40 UTC, Biju Das wrote:
> > > The rpc-if-hyperflash driver can be compiled as a module, but lacks
> > > MODULE_DEVICE_TABLE() and will therefore not be loaded automatically.
> > > Fix this.
> > >
> > > Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver")
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
> >
> > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.
>
> I just realize now this patch got applied but not included in any final PR, sorry about that, I'll
> handle it.
Thanks, I also wondered why this patch was not there in 6.12-rc1, but in next?
Now looks like it is sorted.
Cheers,
Biju
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-10-21 9:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-31 8:08 [PATCH] mtd: hyperbus: rpc-if: Add missing MODULE_DEVICE_TABLE Biju Das
2024-07-31 8:28 ` Geert Uytterhoeven
2024-08-06 17:16 ` Vignesh Raghavendra
2024-08-23 17:31 ` Miquel Raynal
2024-10-21 9:15 ` Miquel Raynal
2024-10-21 9:20 ` Biju Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox