From: Anton Moryakov <ant.v.moryakov@gmail.com>
To: chengzhihao1@huawei.com, linux-mtd@lists.infradead.org
Cc: Anton Moryakov <ant.v.moryakov@gmail.com>
Subject: [PATCH mtd-utils] ubi-utils: Fix integer overflow in mtdinfo.c
Date: Sat, 14 Dec 2024 13:51:28 +0300 [thread overview]
Message-ID: <20241214105128.37995-1-ant.v.moryakov@gmail.com> (raw)
Report of the static analyzer:
The value of an arithmetic expression 'reginfo->offset + i * reginfo->erasesize' is a subject to overflow
because its operands are not cast to a larger data type before performing arithmetic
Corrections explained:
Added casting i and start to unsigned long long
Triggers found by static analyzer Svace.
Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>
---
ubi-utils/mtdinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ubi-utils/mtdinfo.c b/ubi-utils/mtdinfo.c
index 7dff0de..850297b 100644
--- a/ubi-utils/mtdinfo.c
+++ b/ubi-utils/mtdinfo.c
@@ -203,7 +203,7 @@ static void print_region_map(const struct mtd_dev_info *mtd, int fd,
ret_locked = ret_bad = errno_locked = errno_bad = 0;
for (i = 0; i < reginfo->numblocks; ++i) {
- start = reginfo->offset + i * reginfo->erasesize;
+ (unsigned long long)start = reginfo->offset + (unsigned long long)i * reginfo->erasesize;
printf(" %*i: %08lx ", width, i, start);
if (ret_locked != -1) {
--
2.30.2
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next reply other threads:[~2024-12-14 12:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-14 10:51 Anton Moryakov [this message]
2024-12-14 12:19 ` [PATCH mtd-utils] ubi-utils: Fix integer overflow in mtdinfo.c Zhihao Cheng
-- strict thread matches above, loose matches on Subject: below --
2024-12-14 12:31 Anton Moryakov
2024-12-16 1:08 ` Zhihao Cheng
2024-12-13 13:15 Anton Moryakov
2024-12-14 2:56 ` Zhihao Cheng
2024-12-12 17:29 Anton Moryakov
2024-12-12 17:13 Anton Moryakov
2024-12-13 2:29 ` Zhihao Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241214105128.37995-1-ant.v.moryakov@gmail.com \
--to=ant.v.moryakov@gmail.com \
--cc=chengzhihao1@huawei.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox