public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined
@ 2025-02-03 21:30 Rob Herring (Arm)
  2025-02-04  8:41 ` Michal Simek
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-02-03 21:30 UTC (permalink / raw)
  To: Miquel Raynal, Michal Simek, Richard Weinberger,
	Vignesh Raghavendra, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-mtd, devicetree, linux-kernel

Device specific schemas should not allow undefined properties which is
what 'unevaluatedProperties: true' allows. Fix this constraint.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../devicetree/bindings/mtd/arasan,nand-controller.yaml         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
index 15b63bbb82a2..b90d3b48c2f2 100644
--- a/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
+++ b/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
@@ -42,7 +42,7 @@ required:
   - clock-names
   - interrupts
 
-unevaluatedProperties: true
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.47.2


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined
  2025-02-03 21:30 [PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined Rob Herring (Arm)
@ 2025-02-04  8:41 ` Michal Simek
  2025-02-04 19:39 ` Conor Dooley
  2025-02-07 14:47 ` Miquel Raynal
  2 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2025-02-04  8:41 UTC (permalink / raw)
  To: Rob Herring (Arm), Miquel Raynal, Richard Weinberger,
	Vignesh Raghavendra, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-mtd, devicetree, linux-kernel



On 2/3/25 22:30, Rob Herring (Arm) wrote:
> Device specific schemas should not allow undefined properties which is
> what 'unevaluatedProperties: true' allows. Fix this constraint.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>   .../devicetree/bindings/mtd/arasan,nand-controller.yaml         | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
> index 15b63bbb82a2..b90d3b48c2f2 100644
> --- a/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
> +++ b/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
> @@ -42,7 +42,7 @@ required:
>     - clock-names
>     - interrupts
>   
> -unevaluatedProperties: true
> +unevaluatedProperties: false
>   
>   examples:
>     - |

Good thing to do. And we should extend binding to cover other properties which 
are missing in description.
Pretty much remove arasan,has-mdma from DTs and describe power-domains and 
num-cs in binding.

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined
  2025-02-03 21:30 [PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined Rob Herring (Arm)
  2025-02-04  8:41 ` Michal Simek
@ 2025-02-04 19:39 ` Conor Dooley
  2025-02-07 14:47 ` Miquel Raynal
  2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2025-02-04 19:39 UTC (permalink / raw)
  To: Rob Herring (Arm)
  Cc: Miquel Raynal, Michal Simek, Richard Weinberger,
	Vignesh Raghavendra, Krzysztof Kozlowski, Conor Dooley, linux-mtd,
	devicetree, linux-kernel


[-- Attachment #1.1: Type: text/plain, Size: 322 bytes --]

On Mon, Feb 03, 2025 at 03:30:41PM -0600, Rob Herring (Arm) wrote:
> Device specific schemas should not allow undefined properties which is
> what 'unevaluatedProperties: true' allows. Fix this constraint.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined
  2025-02-03 21:30 [PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined Rob Herring (Arm)
  2025-02-04  8:41 ` Michal Simek
  2025-02-04 19:39 ` Conor Dooley
@ 2025-02-07 14:47 ` Miquel Raynal
  2 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2025-02-07 14:47 UTC (permalink / raw)
  To: Michal Simek, Richard Weinberger, Vignesh Raghavendra,
	Krzysztof Kozlowski, Conor Dooley, Rob Herring (Arm)
  Cc: linux-mtd, devicetree, linux-kernel

On Mon, 03 Feb 2025 15:30:41 -0600, Rob Herring (Arm) wrote:
> Device specific schemas should not allow undefined properties which is
> what 'unevaluatedProperties: true' allows. Fix this constraint.
> 
> 

Applied to nand/next, thanks!

[1/1] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined
      commit: 499a4b16a4869a901a9bc601bc1e0b8f60151e93

Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-02-07 14:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-03 21:30 [PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined Rob Herring (Arm)
2025-02-04  8:41 ` Michal Simek
2025-02-04 19:39 ` Conor Dooley
2025-02-07 14:47 ` Miquel Raynal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox