From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3436CC0219D for ; Tue, 11 Feb 2025 00:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=InHKHHgLppOVnXrUbAaRhRf44LBXwOmHYahY192iehU=; b=FEIeT2XSEoi1YY 1RSQe3YF44H1gw2XKTRjctLo400lPBUyi+jveCXktFgYfeBDcVPau4lNhzuO9cG1WHbrZajhEyjyc Jfaml3ZSiESOol/Wmwvg21StQaWz3R01I8TXoTTh+nN+y5zFO0Ffn4vymkDr97SqVmXC4qqkK0+Fv 0CAv0QI/2zMqV3eMhuXA2F7Twfpcct2pmxQK4EXtjd0uts7ga8ZuBVImMXO6NQyzcQJTPb1EJDrcD JsMNBChbum5EXv6IvUkfWRebyE/oDUevpPMe2ZcUYnuiVS9/mGwwntgtExx+surF117pA4AzFUzow ZMmUFVUh9di36jAGDH2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thdiz-00000001v27-3B2a; Tue, 11 Feb 2025 00:02:01 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thdix-00000001v1j-2iRZ for linux-mtd@lists.infradead.org; Tue, 11 Feb 2025 00:02:01 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 4B48AA41D88; Tue, 11 Feb 2025 00:00:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C868C4CEDF; Tue, 11 Feb 2025 00:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739232118; bh=rAzkLZM09qQrVfb6++qtL1NVW6ye9kBKxmsecVL8AX0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q1j87QGsjnUkqkcVlg2v4gnZWuuz2UEGFoQfFx8S5hm6OD3/mp8QI0dCwQT4YmTEr IB2Hu3/xsA738TjmL9hvDacqP3Cn1fn1l38WTUXKf4SHgxcaaqcmtfDjrQUDk9eoqE gB6wCJ5myKFPgBwelHmsgcxfai/gZhPdUPy8zVu8z/cx9kuD9+RM3Bb/ajecRTWHax fVRq4VYORDNdvHY/BD15McfYj6CkfxzLNVClI1u8/Pfa9FJn4JqDpQ7Nyn/Fr2156J CGUj1Kbf4bjxLul7s2ASKdEhbPJl+pwIxxn70nR5a5VyWkDiXJ4SybO3o/a5i5XUEL d5paRyJt5qYuQ== Date: Mon, 10 Feb 2025 18:01:57 -0600 From: Rob Herring To: =?iso-8859-1?Q?J=2E_Neusch=E4fer?= Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Krzysztof Kozlowski , imx@lists.linux.dev, Scott Wood , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Krzysztof Kozlowski , Conor Dooley , Damien Le Moal , Niklas Cassel , Herbert Xu , "David S. Miller" , Lee Jones , Vinod Koul , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , =?iso-8859-1?Q?J=2E_Neusch=E4fer?= , Wim Van Sebroeck , Guenter Roeck , Mark Brown , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, linux-pci@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v2 11/12] dt-bindings: nand: Add fsl,elbc-fcm-nand Message-ID: <20250211000157.GA240011-robh@kernel.org> References: <20250207-ppcyaml-v2-0-8137b0c42526@posteo.net> <20250207-ppcyaml-v2-11-8137b0c42526@posteo.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250207-ppcyaml-v2-11-8137b0c42526@posteo.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_160159_814838_26623B7F X-CRM114-Status: GOOD ( 21.96 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Fri, Feb 07, 2025 at 10:30:28PM +0100, J. Neusch=E4fer wrote: > Formalize the binding already supported by the fsl_elbc_nand.c driver > and used in several device trees in arch/powerpc/boot/dts/. > = > Signed-off-by: J. Neusch=E4fer > --- > = > V2: > - split out from fsl,elbc binding patch > - constrain #address-cells and #size-cells > - add a general description > - use unevaluatedProperties=3Dfalse instead of additionalProperties=3Dfal= se > - fix property order to comply with dts coding style > - include raw-nand-chip.yaml instead of nand-chip.yaml Why? Doesn't look like you use anything from it. I think the correct = thing to use here is just mtd.yaml to pick up partitions. > --- > .../devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml | 68 ++++++++++++++++= ++++++ > 1 file changed, 68 insertions(+) > = > diff --git a/Documentation/devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml= b/Documentation/devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..1de97bb24fa4a83e2ea5d94ab= 822dd0e37baa102 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/fsl,elbc-fcm-nand.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NAND flash attached to Freescale eLBC > + > +description: > + The Freescale Enhanced Local Bus controller (eLBC) contains logic to > + interface with NAND flash, called the NAND Flash Control Machine (FCM). > + This binding describes flash attached to an eLBC using the FCM. > + > +maintainers: > + - J. Neusch=E4fer > + > +allOf: > + - $ref: raw-nand-chip.yaml# > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - fsl,mpc8313-fcm-nand > + - fsl,mpc8315-fcm-nand > + - fsl,mpc8377-fcm-nand > + - fsl,mpc8378-fcm-nand > + - fsl,mpc8379-fcm-nand > + - fsl,mpc8536-fcm-nand > + - fsl,mpc8569-fcm-nand > + - fsl,mpc8572-fcm-nand > + - fsl,p1020-fcm-nand > + - fsl,p1021-fcm-nand > + - fsl,p1025-fcm-nand > + - fsl,p2020-fcm-nand > + - const: fsl,elbc-fcm-nand > + - const: fsl,elbc-fcm-nand > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + localbus { > + #address-cells =3D <2>; > + #size-cells =3D <1>; > + > + nand@1,0 { > + compatible =3D "fsl,mpc8315-fcm-nand", > + "fsl,elbc-fcm-nand"; > + reg =3D <0x1 0x0 0x2000>; > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + }; > + }; > = > -- = > 2.48.0.rc1.219.gb6b6757d772 > = ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/