[PATCH v3 14/16] fsi: i2cr: Replace open-coded parity calculation with parity64()

Kuan-Wei Chiu
2025-03-06T17:34:08Z

Refactor parity calculations to use the standard parity64() helper.
This change eliminates redundant implementations and improves code
efficiency.

Co-developed-by: Yu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
Changes in v3:
- Change parity ^= parity64(v) to parity != parity64(v).

drivers/fsi/fsi-master-i2cr.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/fsi/fsi-master-i2cr.c b/drivers/fsi/fsi-master-i2cr.c
index 46511236bbca..3356c478e395 100644
--- a/drivers/fsi/fsi-master-i2cr.c
+++ b/drivers/fsi/fsi-master-i2cr.c
@@ -44,15 +44,9 @@ static bool i2cr_check_parity32(u32 v, bool parity)

static bool i2cr_check_parity64(u64 v)
{
- u32 i;
bool parity = I2CR_INITIAL_PARITY;

- for (i = 0; i < 64; ++i) {
- if (v & (1llu << i))
- parity = !parity;
- }
-
- return parity;
+ return parity != parity64(v);
}

static u32 i2cr_get_command(u32 address, bool parity)
--
2.34.1