Re: [PATCH] fscrypt: don't use hardware offload Crypto API drivers

Simon Richter
2025-06-12T02:43:59Z

Hi,

On 6/12/25 05:58, Eric Biggers wrote:

> But
> otherwise this style of hardware offload is basically obsolete and has
> been superseded by hardware-accelerated crypto instructions directly on
> the CPU as well as inline storage encryption (UFS/eMMC).

For desktop, yes, but embedded still has quite a few of these, for
example the STM32 crypto offload engine, and I expect quite a few FPGA
based implementations exist, so this would require vendors to maintain a
fork to keep their out-of-tree drivers functional when updating the kernel.

POWER also has an asynchronous offload engine with AES, SHA and gzip
support, these are significantly faster than the CPU.

If a buggy engine passes self-test, can this simply be fixed by adding
more tests? :>

Simon