public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Florian Fuchs <fuchsfl@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rich Felker <dalias@libc.org>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	Florian Fuchs <fuchsfl@gmail.com>
Subject: [PATCH 1/3] sh: maple: Fix build error due to missing include of linux/device.h
Date: Mon, 17 Nov 2025 23:44:06 +0100	[thread overview]
Message-ID: <20251117224408.498449-2-fuchsfl@gmail.com> (raw)
In-Reply-To: <20251117224408.498449-1-fuchsfl@gmail.com>

Commit 313162d0b838 ("device.h: audit and cleanup users in main include
dir") removed the include of linux/device.h. Revert this, as
linux/maple.h embeds struct device via struct maple_device, which
requires the definition. Otherwise results in build error: field 'dev'
has incomplete type.

Fixes: 313162d0b838 ("device.h: audit and cleanup users in main include dir")
Signed-off-by: Florian Fuchs <fuchsfl@gmail.com>
---
 include/linux/maple.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/maple.h b/include/linux/maple.h
index 3be4e567473c..22f2930251ed 100644
--- a/include/linux/maple.h
+++ b/include/linux/maple.h
@@ -2,10 +2,9 @@
 #ifndef __LINUX_MAPLE_H
 #define __LINUX_MAPLE_H
 
+#include <linux/device.h>
 #include <mach/maple.h>
 
-struct device;
-
 /* Maple Bus command and response codes */
 enum maple_code {
 	MAPLE_RESPONSE_FILEERR =	-5,

base-commit: 97315e7c901a1de60e8ca9b11e0e96d0f9253e18
-- 
2.43.0


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2025-11-17 22:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17 22:44 [PATCH 0/3] mtd: maps: vmu-flash: Fix build and runtime errors Florian Fuchs
2025-11-17 22:44 ` Florian Fuchs [this message]
2025-11-17 22:44 ` [PATCH 2/3] mtd: maps: vmu-flash: Fix fault in unaligned fixup Florian Fuchs
2025-11-17 22:44 ` [PATCH 3/3] mtd: maps: vmu-flash: Fix NULL pointer dereference in initialization Florian Fuchs
2025-11-18  7:31 ` [PATCH 0/3] mtd: maps: vmu-flash: Fix build and runtime errors John Paul Adrian Glaubitz
2025-11-19 21:36   ` Artur Rojek
2025-11-19 21:44     ` Florian Fuchs
2025-11-19 21:54       ` Artur Rojek
2025-11-20  8:52         ` Florian Fuchs
2025-11-20  9:09           ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251117224408.498449-2-fuchsfl@gmail.com \
    --to=fuchsfl@gmail.com \
    --cc=dalias@libc.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox