[PATCH] ubiattach: fix wording in usage example

[PATCH] ubiattach: fix wording in usage example

[Mohammad Rahimi]

The usage example 4 describing reserved eraseblocks had awkward and
slightly incorrect phrasing ("is total flash chip eraseblocks count").
Reword it for clarity and readability without changing the meaning.

Signed-off-by: Mohammad Rahimi <rahimi.mhmmd@gmail.com>
---
 ubi-utils/ubiattach.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ubi-utils/ubiattach.c b/ubi-utils/ubiattach.c
index e758dab..11e171b 100644
--- a/ubi-utils/ubiattach.c
+++ b/ubi-utils/ubiattach.c
@@ -92,9 +92,9 @@ static const char usage[] =
 "           and create UBI device number 3 (ubi3)\n"
 "Example 4: " PROGRAM_NAME " -m 1 -b 25 - attach /dev/mtd1 to UBI and reserve\n"
 "           25*C/1024 eraseblocks for bad block handling, where C is the flash\n"
-"           is total flash chip eraseblocks count, that is flash chip size in\n"
-"           eraseblocks (including bad eraseblocks). E.g., if the flash chip\n"
-"           has 4096 PEBs, 100 will be reserved.";
+"           chip total eraseblocks count, that is flash chip size in eraseblocks\n"
+"           (including bad eraseblocks). E.g., if the flash chip has 4096 PEBs,\n"
+"           100 will be reserved.";
 
 static const struct option long_options[] = {
 	{ .name = "devn",            .has_arg = 1, .flag = NULL, .val = 'd' },
-- 
2.51.0


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] ubiattach: fix wording in usage example

[Zhihao Cheng]

在 2026/2/12 9:35, Mohammad Rahimi 写道:
> The usage example 4 describing reserved eraseblocks had awkward and
> slightly incorrect phrasing ("is total flash chip eraseblocks count").
> Reword it for clarity and readability without changing the meaning.
> 
> Signed-off-by: Mohammad Rahimi <rahimi.mhmmd@gmail.com>
> ---
>   ubi-utils/ubiattach.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> 
> diff --git a/ubi-utils/ubiattach.c b/ubi-utils/ubiattach.c
> index e758dab..11e171b 100644
> --- a/ubi-utils/ubiattach.c
> +++ b/ubi-utils/ubiattach.c
> @@ -92,9 +92,9 @@ static const char usage[] =
>   "           and create UBI device number 3 (ubi3)\n"
>   "Example 4: " PROGRAM_NAME " -m 1 -b 25 - attach /dev/mtd1 to UBI and reserve\n"
>   "           25*C/1024 eraseblocks for bad block handling, where C is the flash\n"
> -"           is total flash chip eraseblocks count, that is flash chip size in\n"
> -"           eraseblocks (including bad eraseblocks). E.g., if the flash chip\n"
> -"           has 4096 PEBs, 100 will be reserved.";
> +"           chip total eraseblocks count, that is flash chip size in eraseblocks\n"
> +"           (including bad eraseblocks). E.g., if the flash chip has 4096 PEBs,\n"
> +"           100 will be reserved.";
>   
>   static const struct option long_options[] = {
>   	{ .name = "devn",            .has_arg = 1, .flag = NULL, .val = 'd' },
> 


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] ubiattach: fix wording in usage example

[David Oberhollenzer]

Applied to mtd-utils.git master.

Thanks,

David


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/