From: Runyu Xiao <runyu.xiao@seu.edu.cn>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <mwalle@kernel.org>,
Takahiro Kuwano <takahiro.kuwano@infineon.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Runyu Xiao <runyu.xiao@seu.edu.cn>,
Jianhao Xu <jianhao.xu@seu.edu.cn>
Subject: [PATCH v4 0/2] mtd: spi-nor: core: Fix RWW wait locking
Date: Wed, 19 Aug 2026 22:03:35 +0800 [thread overview]
Message-ID: <20260819140337.36775-1-runyu.xiao@seu.edu.cn> (raw)
In-Reply-To: <0a15f6e8-f1ca-4945-9bd5-2b64a2802a58@linaro.org>
The RWW wait helpers must not block while evaluating the wait
condition. In the current code, spi_nor_rww_start_exclusive() can leave
nor->lock held on a false return. Also, if a killable RWW wait is
interrupted after spi_nor_prep(), the controller setup must be undone.
Patch 1 switches the four RWW start helpers to conditional scoped mutex
guards so the wait condition never sleeps and the mutex is always
released before returning.
Patch 2 unprepares the controller on interrupted waits in the three
spi_nor_prep_and_lock() helpers.
Runyu Xiao (2):
mtd: spi-nor: core: Fix mutex leak in spi_nor_rww_start_exclusive()
mtd: spi-nor: core: Unprepare after interrupted RWW wait
drivers/mtd/spi-nor/core.c | 93 ++++++++++++++++++++++----------------
1 file changed, 54 insertions(+), 39 deletions(-)
base-commit: 2b533e775aec580cf60074417f4ca00ac9cf3580
--
2.34.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2026-08-19 14:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-09 8:42 [PATCH] mtd: spi-nor: scope the exclusive RWW lock Runyu Xiao
2026-08-10 8:25 ` Michael Walle
2026-08-10 12:47 ` Miquel Raynal
2026-08-11 4:13 ` [PATCH v2] " Runyu Xiao
2026-08-11 7:51 ` Miquel Raynal
2026-08-11 8:31 ` [PATCH v3] mtd: spi-nor: use guard() in spi_nor_rww_start_exclusive Runyu Xiao
2026-08-11 8:41 ` Miquel Raynal
2026-08-11 10:11 ` Tudor Ambarus
2026-08-11 10:42 ` Tudor Ambarus
2026-08-11 14:36 ` Miquel Raynal
2026-08-11 15:38 ` Miquel Raynal
2026-08-12 10:19 ` Tudor Ambarus
2026-08-19 14:03 ` Runyu Xiao [this message]
2026-08-19 14:03 ` [PATCH v4 1/2] mtd: spi-nor: core: Fix mutex leak in spi_nor_rww_start_exclusive() Runyu Xiao
2026-08-25 12:29 ` Miquel Raynal
2026-08-27 8:26 ` [PATCH v5] " Runyu Xiao
2026-08-27 8:33 ` Miquel Raynal
2026-08-27 8:45 ` Runyu Xiao
2026-08-19 14:03 ` [PATCH v4 2/2] mtd: spi-nor: core: Unprepare after interrupted RWW wait Runyu Xiao
2026-08-25 12:18 ` Miquel Raynal
2026-08-12 9:49 ` [PATCH v3] mtd: spi-nor: use guard() in spi_nor_rww_start_exclusive Tudor Ambarus
2026-08-11 8:50 ` [PATCH v2] mtd: spi-nor: scope the exclusive RWW lock Michael Walle
2026-08-11 10:05 ` [PATCH] " Tudor Ambarus
2026-08-12 6:14 ` Michael Walle
2026-08-12 9:48 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819140337.36775-1-runyu.xiao@seu.edu.cn \
--to=runyu.xiao@seu.edu.cn \
--cc=jianhao.xu@seu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=takahiro.kuwano@infineon.com \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox