From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F0CE60A3801 for ; Tue, 27 Oct 2026 22:39:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=vkynIi3+; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=Otcw1/E7 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Unsubscribe-Post:List-Owner; bh=QCgiXuuiZU9b0VRTzYRMfX/5Tcl5xs7PxZc+ykh0+Lg=; b=vkynIi3+bbugWE0pEvUmckjUMo 2+orQhEHqbjRrpHIg/aiYoMqLNClFjoPED01umPSAD9WGoKL9ao/RwfWDUIzwhhUnbwmL7BnXIpMa S721fr+/pbJA6HxFpR8k32QGYkd4QSXxc9WeGs1ohLbLXX7080/dtkKcOgUsdiiMLJXQ/4zjqodYz Op+FWJEygoU6v3oJBALT5cPFS3DTXzOdIAPx1xz+TACdG04RBb0XU4AaK9I5ujzoC8LdFV6PQB9sV rYJykAbQE39ddUBnU53Rsaz3U7VcmmryHeJEln5XlXzDcQ1MV9uX/ll4/Wp6r73Zv1SF51tjtDk3q BPqYQeFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLpp8-00000005r0m-0pWt; Tue, 27 Oct 2026 22:39:18 +0000 Received: from mail-dy1-x1348.google.com ([2607:f8b0:4864:20::1348]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLpp4-00000005qzc-1ZFN for linux-mtd@lists.infradead.org; Tue, 27 Oct 2026 22:39:16 +0000 Received: by mail-dy1-x1348.google.com with SMTP id 5a478bee46e88-33c35f5ca6cso579333eec.1 for ; Tue, 27 Oct 2026 15:39:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793140752; x=1793745552; darn=lists.infradead.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dWBu3E1+9O630leKOxiPf33Qem+izCRkowC6gFS9sVM=; b=Otcw1/E7YlfHptyyP5mMox03awd4ObzedgMBvuCezqnZDhTdloE/Pz8FCAHOFp7wmM ddIFbdt+6q1uOfLgLIQYUoMbHQu1U78UXrue6/qx9q7MAhG6Bxf7VRWeWU6J9+X2rQwL 7dODyHPYLMGiAmzz1K9v/OEwpi1ZVKULiwPBf64kQ4ET08AdMQaDfONnbDsiYGogOqmH sxfYdZ9jCGOrtvYce7QXg0vgztC8rZ1Z01KYCXCzgJUcWkEaHMTpVoj9uFdur54LHzuN 2lVm8t7hnEr9o95hbNbotJhjGfUzRle66gv9OxlPjQisbVPsWQIgR5CmTY+ljaQqKhMY puNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793140752; x=1793745552; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dWBu3E1+9O630leKOxiPf33Qem+izCRkowC6gFS9sVM=; b=Ixvob7KyTQFHJ+EeBewCjWl/8pvWk9joeEN+tR39bnz2PwxQX19KEGWkkZFE1bb56K T7gh3QHcK0s0zMoxhOJbYbfxzAVK69Ck27YgpJQLqKPRz44MxhChIulnwiRSMgUVkRot Q14S7KcMNxK3KSMnPphtmDCkpufJxtKkjW/IvoSERVeEm9EEn/O7CPeSep1Tc22od/fI Re9K0I/orDeQbPqu50uUYFODSG27eOhBfJIeQRt6nDE3qu10ZX1iLePeTIHmmjHit09x a2zcS73YnDl/CDbNrB0Xw+kFgXIDRyNSWHACubfdotJLNge0HJVoptINNKvF5pN2P/c8 6J/Q== X-Forwarded-Encrypted: i=1; AKwUvBy2X+oFqi6jIVpqBy8q9yF3uU6aOv4pWsQOLJwe7Oq7lBZ/q8W8fM8dxrcQUE6qFPXBVsefS49fDAo=@lists.infradead.org X-Gm-Message-State: AFq9FYJArNvKFuQt34so7TH5WsxVl7nTrecRNKH7dMxiSnSTzMk16KlW ZMyVONECu76iQBnGS5aAeC1bfomqrVE8VYPTiZrCgsypboV/rqQZE/8CQisXWWiIepHVmwgC2p7 QX+buRa6yrQ== X-Received: from dybnl11.prod.google.com ([2002:a05:7300:cf8b:b0:36a:117:523b]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:693c:250d:b0:369:f5f6:36a7 with SMTP id 5a478bee46e88-36a2014b887mr1132027eec.16.1793140751881; Tue, 27 Oct 2026 15:39:11 -0700 (PDT) Date: Tue, 27 Oct 2026 15:38:36 -0700 In-Reply-To: <20261027223847.652884-1-irogers@google.com> X-Archived-By: Mime-Version: 1.0 References: <20261027223847.652884-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.313.g2479322e68-goog Message-ID: <20261027223847.652884-2-irogers@google.com> Subject: [PATCH v2 1/9] Compiler Attributes: Add __must_init macro From: Ian Rogers To: Kees Cook , Greg Kroah-Hartman , Miguel Ojeda , "Rafael J . Wysocki" , Danilo Krummrich Cc: Nathan Chancellor , Nick Desaulniers , Miguel Ojeda , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Zhongqiu Han , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers , Jonathan Corbet , Shuah Khan , Randy Dunlap , Andy Whitcroft , Joe Perches X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261027_153914_449043_3F7BDBAF X-CRM114-Status: GOOD ( 14.28 ) X-Spam-Score: -9.5 (---------) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" X-Spam-Status: No, score=-22.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Clang supports the 'require_explicit_initialization' attribute on struct fields to indicate that a field must be initialized explicitly by the user when the object is constructed. When an aggregate initializer or uninitialized variable omits an annotated field, Clang emits a -Wuninitialized-explicit-init warning (enabled by default). Add the __must_init macro to include/linux/compiler_attributes.h (which is included by include/linux/compiler_types.h and include/linux/compiler.h) so kernel structs with error-prone initialization (such as mandatory callbacks or cleanup handlers) can enforce explicit initialization at compile time, as discussed at the Linux Plumbers Conference. The shorter __must_init spelling, rather than the attribute's full name, keeps annotated struct members readable and was suggested by Greg Kroah-Hartman. Note that Clang does not yet diagnose file-scope objects declared without any initializer (initializers at file scope that omit the field are diagnosed), see https://github.com/llvm/llvm-project/issues/232483. Also teach Sphinx (Documentation/conf.py), kernel-doc (tools/lib/python/kdoc/xforms_lists.py), and checkpatch.pl about the new attribute macro. Link: https://lpc.events/event/20/contributions/2392/ Link: https://lore.kernel.org/lkml/2026101532-fantastic-deafness-e04c@gregkh/ Acked-by: Miguel Ojeda Reviewed-by: Nick Desaulniers Reviewed-by: Nathan Chancellor Acked-by: Greg Kroah-Hartman Signed-off-by: Ian Rogers --- Documentation/conf.py | 1 + include/linux/compiler_attributes.h | 12 ++++++++++++ scripts/checkpatch.pl | 1 + tools/lib/python/kdoc/xforms_lists.py | 1 + 4 files changed, 15 insertions(+) diff --git a/Documentation/conf.py b/Documentation/conf.py index 5ab26ce89daf..baaa4035258c 100644 --- a/Documentation/conf.py +++ b/Documentation/conf.py @@ -203,6 +203,7 @@ c_id_attributes = [ "__noreturn", "__packed", "__pure", + "__must_init", "__section", "__always_unused", "__maybe_unused", diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h index 476c4c560d17..b9c0b56dd22e 100644 --- a/include/linux/compiler_attributes.h +++ b/include/linux/compiler_attributes.h @@ -322,6 +322,18 @@ */ #define __pure __attribute__((__pure__)) +/* + * Optional: not supported by gcc + * Optional: only supported since clang >= 20.0 + * + * clang: https://clang.llvm.org/docs/AttributeReference.html#require-explicit-initialization + */ +#if __has_attribute(__require_explicit_initialization__) +# define __must_init __attribute__((__require_explicit_initialization__)) +#else +# define __must_init +#endif + /* * gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-section-function-attribute * gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html#index-section-variable-attribute diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c9840f5219c2..5232f66d2b80 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6860,6 +6860,7 @@ sub process { "noreturn" => "__noreturn", "packed" => "__packed", "pure" => "__pure", + "require_explicit_initialization" => "__must_init", "section" => "__section", "used" => "__used", "weak" => "__weak" diff --git a/tools/lib/python/kdoc/xforms_lists.py b/tools/lib/python/kdoc/xforms_lists.py index 320f977c5bac..3c744cbd2f34 100644 --- a/tools/lib/python/kdoc/xforms_lists.py +++ b/tools/lib/python/kdoc/xforms_lists.py @@ -36,6 +36,7 @@ class CTransforms: (CMatch("CRYPTO_MINALIGN_ATTR"), ""), (CMatch("__private"), ""), (CMatch("__rcu"), ""), + (CMatch("__must_init"), ""), (CMatch("____cacheline_aligned_in_smp"), ""), (CMatch("____cacheline_aligned"), ""), (CMatch("__cacheline_group_(?:begin|end)"), ""), -- 2.56.0.313.g2479322e68-goog ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/