From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FF9760A3802 for ; Tue, 27 Oct 2026 22:39:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ArhrrUt9; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=AFjscUXM DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Unsubscribe-Post:List-Owner; bh=hyRp9pWXfYj85Z5J0ebq8iQzqzXVW7/D0VhkkawBrJg=; b=ArhrrUt9sWu8jfmg88V5Pkhgn0 PSxLaYiJW4wksXXhCv/Y3xohGqlzSLcfHwC/DHRR9p2WT1AIQrNrG0Z45pj2RoenMBc3Aso7SD+Kc TQfl59OVUWt66IBWQ3K7YIVLWba/f+6xgU3FK0yO0FU1PXl9sXiA6CaVPQW0Jr0SQ+jLHn8VwjSBg Qo80wAb3t3jY+d2NiYUw1d+Rqrrstf24tQF6/N7e4WcL2zn/NqrhwJOcMVsGkUdYgR40IxKxuCoDS TUwsdX9Ha67qFRrQt71OIZlqjE7FWw3Sa1moo4P5F/TueoQIuc4pSqzqCjMOzPwCl0/1CovbxY0ma HGqPIG1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLpp9-00000005r16-1KTE; Tue, 27 Oct 2026 22:39:19 +0000 Received: from mail-dy1-x1348.google.com ([2607:f8b0:4864:20::1348]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLpp7-00000005r05-0Sit for linux-mtd@lists.infradead.org; Tue, 27 Oct 2026 22:39:18 +0000 Received: by mail-dy1-x1348.google.com with SMTP id 5a478bee46e88-341eff9e381so708237eec.1 for ; Tue, 27 Oct 2026 15:39:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793140756; x=1793745556; darn=lists.infradead.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kZ/TSWTZAJNbAAfYXfetESQgQ8bp7xksXUAoJHJHiFs=; b=AFjscUXMRza82GpxxXLwsVXxZa7hnHz3TK73y7T7Wtj+7ekG0EeHxr/ChYfSn1HWVN 0jU6+/nEzsoTOeXCUMEsq5bC6FthnD8x4b9fEWa7EvbdgOwwGJBIsDeAIfnIJ1ypZe7J 0WSJNOsmCi3W9XGYIecnivCgDqY2tOJuUB/pkbpLcoZ6Gqa2GQPVQWm+w6/t47Hfl+XR zsyV7V2ry4Y5uGeBkcZA69MRc1tyuHCI7xQHLURiCZ+Uj/dV8IONf+ep8RWUpSy1PbIm Yaj9UG3Plq9ls5dKzRpM/kOqR7yUWxbMexfXfmWwg1+Y8ym4SgpB0XfdoQ8s2UH1u+DI zhng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793140756; x=1793745556; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kZ/TSWTZAJNbAAfYXfetESQgQ8bp7xksXUAoJHJHiFs=; b=nLeLlQ6/XYnijBcWC+9ld9KsBs/s2s3+VWOEV7QxmzKvElF5oh3sJPPfTjkUzVgnAT LQKBynx2D6J+8Toe3ZD3eZfhuuCWg+lc9q7awL93TgW4pdo4Zna3gEBi9YBpq0BmKXUg OabpiCej2h/UVyppDBVBKOx/VoQgaltq+A+pRhj1InMtFW+eY5cIo5zw8nnxog8veA2c 9Ba91e1BS206qqtCZ3yZ3H4/cvhmFQWkvAq0UN64q2ns4wMfEkClGP9I1xUV1VVgVT8N /m2l/avSRPbOIvP8Yg7NaqvxJsQQZjbd5+FXOI0O1Fye9T+zvS3+/FHNu21+kMsuIiEC 8LbQ== X-Forwarded-Encrypted: i=1; AKwUvBxd9txGAKzELLzan6G95GitCN1xJZ2DhEb/V20VQiwi+aHyYQJXvWTusipbtn7wFXYYCrJHN/f3Lcc=@lists.infradead.org X-Gm-Message-State: AFq9FYLTvC4v9+uCvVeVcYaMYImaoysOUK74eHayJscn+jP0b55jOP0n Ezk5iYx7mmR3rOS+xO7l6vuWtbDkxJrSHvLExTAOyfL+chpQc8d4ttm4TVfPJHJX6Dx4Ag+jGIX BqiQj7U1ZlA== X-Received: from dlbrl28.prod.google.com ([2002:a05:7022:f51c:b0:192:91:5cc4]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:618:b0:19f:527d:96da with SMTP id a92af1059eb24-1a6cdd3e006mr1194989c88.33.1793140755024; Tue, 27 Oct 2026 15:39:15 -0700 (PDT) Date: Tue, 27 Oct 2026 15:38:37 -0700 In-Reply-To: <20261027223847.652884-1-irogers@google.com> X-Archived-By: Mime-Version: 1.0 References: <20261027223847.652884-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.313.g2479322e68-goog Message-ID: <20261027223847.652884-3-irogers@google.com> Subject: [PATCH v2 2/9] powerpc/secvar: Add missing kobject release callback to secvar_ktype From: Ian Rogers To: Kees Cook , Greg Kroah-Hartman , Miguel Ojeda , "Rafael J . Wysocki" , Danilo Krummrich Cc: Nathan Chancellor , Nick Desaulniers , Miguel Ojeda , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Zhongqiu Han , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , "Ritesh Harjani (IBM)" , Shrikanth Hegde , Nayna Jain , Eric Richter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261027_153917_151641_55F47F7E X-CRM114-Status: GOOD ( 11.30 ) X-Spam-Score: -9.5 (---------) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 In add_var(), a struct kobject is dynamically allocated with kzalloc_obj() and initialized with secvar_ktype. If kobject_add() or sysfs_create_file() fails, kobject_put(kobj) is called to clean up. However, secvar_ktype does not define a .release callback, which results in a memory leak of kobj (and a pr_debug warning in kobject_cleanup() when CONFIG_DEBUG_KOBJECT_RELEASE is enabled). Provide a secvar_release() callback that calls kfree(kobj). Fixes: bd5d9c743d38 ("powerpc: expose secure variables to userspace via sysfs") Signed-off-by: Ian Rogers --- arch/powerpc/kernel/secvar-sysfs.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/powerpc/kernel/secvar-sysfs.c b/arch/powerpc/kernel/secvar-sysfs.c index 395399bbab2c..f3f6ac25ea78 100644 --- a/arch/powerpc/kernel/secvar-sysfs.c +++ b/arch/powerpc/kernel/secvar-sysfs.c @@ -126,7 +126,13 @@ static const struct attribute_group secvar_attr_group = { }; __ATTRIBUTE_GROUPS(secvar_attr); +static void secvar_release(struct kobject *kobj) +{ + kfree(kobj); +} + static const struct kobj_type secvar_ktype = { + .release = secvar_release, .sysfs_ops = &kobj_sysfs_ops, .default_groups = secvar_attr_groups, }; -- 2.56.0.313.g2479322e68-goog ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/