From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26DA160A2628 for ; Thu, 19 Nov 2026 19:25:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=EvG1zuvt; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=QX6dohm0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Unsubscribe-Post:List-Owner; bh=2DhRl6L7VRn/QbG+PSB4INu5qCswMPeg//U2134VXiw=; b=EvG1zuvt7aWMN6qIgmwKFT8+1q gHVYTSdGq3ac3Z6xJmsU/SFV2VDnNUqm3mrqTNI9Uz7PI78JjfRm2gzj0dDoyabbvMmgsxIokAI2k STagUpP/s9wY9eSBYe1eQEAV62hMfn3ZuICMNNQlmLs/T4ItLW9nDRWJSg3835JMvOgNs5ZXujQ2q QRFm8dvp6gpcat51xIBepg8iW4jQD6g253vphSxElyaPe4/jGKOWDZfioQmL0af6e40ZF3OO8X0YQ HlgiEXHKZN/V+zqelIc9nfA6jWXCnt3y5zTWenmGMsmYxAuq6TWQp8UfCMR1K6siUVTD9jOe0A1pD NvCF9Ctg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xU7lP-0000000DBym-3gG9; Thu, 19 Nov 2026 19:25:43 +0000 Received: from mail-oi1-x247.google.com ([2607:f8b0:4864:20::247]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xU7lL-0000000DBw9-0TOA for linux-mtd@lists.infradead.org; Thu, 19 Nov 2026 19:25:42 +0000 Received: by mail-oi1-x247.google.com with SMTP id 5614622812f47-547ae874949so264548b6e.2 for ; Thu, 19 Nov 2026 11:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795116338; x=1795721138; darn=lists.infradead.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rEPVdW1UHjKh7bwOu3YUjmxSg8vF1ESXVYVOzAB45kQ=; b=QX6dohm0EyHyG47ARuBaQ4F1rUnWrFF5P3cDzgaUJAFfXVLORqOMOG7tQzd0IpEqoo rccdPmFRiliq6B8D+nzflonfbOxy6OgnB0mnPk923YhEAHXvxFyFj1PwQpreVMnQhWgH RqhIuX2srJ+nX8TnRCm4SNiRJYL8uBexF0aGMMlx+39wwWlSR4JiPI991LuFj5kn/zgE N1NX8dOsaZ89UXpiK6uI/DETd71h2PxbDF7OMJnQ0k+QL4HJfABe0hbUaK0JMc4I5IzP FeDWgLTwMB8kFW2vqJRfTWliJGEIVPyjhVuB+zHuwZpiDke8bocrrX4aV1D0nomt6gCc oONw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795116338; x=1795721138; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rEPVdW1UHjKh7bwOu3YUjmxSg8vF1ESXVYVOzAB45kQ=; b=wtHmfh+zlT547R7URXDLjZitI9cdC7XtNysAKLK4/r6UEUavvVwVx1Wtylq1ziNtPE Y9pHS8A9BniSVig2t4j3NXyKedOE+ITaOhx9Ocp+YaY11CKNGBprYn3Yg4bBN16i2D/s rcESCWuDfw/rGSAwit3q58yrFAwRvvmp9OWT0o/gJTB1asRnf3zSNI2RWwKFDfTSq5do mP+QMUmusVkwKCIM0EDGiU1mkSPbDlRRIBdv/R9FO7NzO8vibrqmV+JjTzdoNzdbHkBb 7S0cIKaf8HNd37cJDCkk+b48Oum90JQOF7QwOm0+XLe6VE9l/wZzPo9/BrZCSHvOqG76 sP9g== X-Forwarded-Encrypted: i=1; AL+hErHdnx8+/glUdGHgr1IL1MxJd7+10T3Rhdwi9vqsDKkPxo4gldb/QYDgC2gTtrDis3X+MIO/Sya7fzY=@lists.infradead.org X-Gm-Message-State: APuU4Z+RCPep/Pue7VGM4GLAbkxYrLYckl3TyCgKsIrUj543omLMpprQ KqjsjF2QQ3JtQjr+kYkIUxCntLrGb9f7lqu+6naLpuru/wclVrJNgz9R+Xtkpl0n5iHQLAwqcQ6 nDqegvbdqYg== X-Received: from ilmp8.prod.google.com ([2002:a92:c608:0:b0:51e:1b8:eceb]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6808:c110:b0:576:4595:9836 with SMTP id 5614622812f47-57a0ba52419mr994155b6e.40.1795116337420; Thu, 19 Nov 2026 11:25:37 -0800 (PST) Date: Thu, 19 Nov 2026 11:25:13 -0800 In-Reply-To: <20261119192520.1983406-1-irogers@google.com> X-Archived-By: Mime-Version: 1.0 References: <20261119192520.1983406-1-irogers@google.com> X-Mailer: git-send-email 2.56.1.750.gf70dc682cf-goog Message-ID: <20261119192520.1983406-3-irogers@google.com> Subject: [PATCH v4 2/9] powerpc/secvar: Add missing kobject release callback to secvar_ktype From: Ian Rogers To: Danilo Krummrich , Greg Kroah-Hartman , Kees Cook , Miguel Ojeda , "Rafael J . Wysocki" Cc: Madhavan Srinivasan , Srish Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Mimi Zohar , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Nathan Chancellor , Nick Desaulniers , Viresh Kumar , Zhongqiu Han , Alexander Aring , Felix Kuehling , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261119_112539_182949_6E9775AB X-CRM114-Status: GOOD ( 11.02 ) X-Spam-Score: -9.5 (---------) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 In add_var(), a struct kobject is dynamically allocated with kzalloc_obj() and initialized with secvar_ktype. If kobject_add() or sysfs_create_file() fails, kobject_put(kobj) is called to clean up. However, secvar_ktype does not define a .release callback, which results in a memory leak of kobj (and a pr_debug warning in kobject_cleanup() when CONFIG_DEBUG_KOBJECT_RELEASE is enabled). Provide a secvar_release() callback that calls kfree(kobj). Fixes: bd5d9c743d38 ("powerpc: expose secure variables to userspace via sysfs") Reviewed-by: Srish Srinivasan Acked-by: Madhavan Srinivasan Signed-off-by: Ian Rogers --- arch/powerpc/kernel/secvar-sysfs.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/powerpc/kernel/secvar-sysfs.c b/arch/powerpc/kernel/secvar-sysfs.c index 395399bbab2c..f3f6ac25ea78 100644 --- a/arch/powerpc/kernel/secvar-sysfs.c +++ b/arch/powerpc/kernel/secvar-sysfs.c @@ -126,7 +126,13 @@ static const struct attribute_group secvar_attr_group = { }; __ATTRIBUTE_GROUPS(secvar_attr); +static void secvar_release(struct kobject *kobj) +{ + kfree(kobj); +} + static const struct kobj_type secvar_ktype = { + .release = secvar_release, .sysfs_ops = &kobj_sysfs_ops, .default_groups = secvar_attr_groups, }; -- 2.56.1.708.g77570a6a1d-goog ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/