From: Mike Frysinger <vapier@gentoo.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] include/common.h: fix build against recent 0.9.33 uClibc
Date: Tue, 15 Apr 2014 19:09:45 -0400 [thread overview]
Message-ID: <2055220.5Wt3obd1St@vapier> (raw)
In-Reply-To: <f4242477d038f71b8dce112047fae342878ebcf3.1397593003.git.baruch@tkos.co.il>
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
On Tue 15 Apr 2014 23:16:43 Baruch Siach wrote:
> An implementation of rpmatch() was backported to the 0.9.33 branch of
> uClibc. So the uClibc version check introduced in commit 50c9e11f7e
> (include/common.h: fix build against current uClibc) is not enough. Rename
> the local rpmatch() implementation to avoid collision.
>
> Cc: Mike Frysinger <vapier@gentoo.org>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> include/common.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/common.h b/include/common.h
> index 3b1366e927c4..838dc757bdf1 100644
> --- a/include/common.h
> +++ b/include/common.h
> @@ -107,7 +107,8 @@ extern "C" {
> #if __UCLIBC_MAJOR__ == 0 && \
> (__UCLIBC_MINOR__ < 9 || \
> (__UCLIBC_MINOR__ == 9 && __UCLIBC_SUBLEVEL__ < 34))
> -static inline int rpmatch(const char *resp)
> +#define rpmatch __rpmatch
probably want to:
#undef rpmatch
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-15 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 20:16 [PATCH] include/common.h: fix build against recent 0.9.33 uClibc Baruch Siach
2014-04-15 23:09 ` Mike Frysinger [this message]
2014-04-16 4:27 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2055220.5Wt3obd1St@vapier \
--to=vapier@gentoo.org \
--cc=baruch@tkos.co.il \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).