From: Arnd Bergmann <arnd@arndb.de>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: pekon <pekon@pek-sem.com>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH] nand: omap2: fix building with CONFIG_MTD_NAND_OMAP_BCH=m
Date: Wed, 01 Oct 2014 12:46:39 +0200 [thread overview]
Message-ID: <2061777.ebdfGlRHlL@wuerfel> (raw)
In-Reply-To: <20141001102419.GA2085@arch.hh.imgtec.org>
On Wednesday 01 October 2014 07:24:19 Ezequiel Garcia wrote:
> >
> > config MTD_NAND_OMAP_BCH_BUILD
> > def_tristate MTD_NAND_OMAP2 && MTD_NAND_OMAP_BCH
> >
> > which makes it 'm' if MTD_NAND_OMAP_BCH is set to m.
> >
>
> Just to clarify, you are talking about this one being the correct one,
> right?
>
> http://article.gmane.org/gmane.linux.ports.arm.omap/118488
> "[PATCH 3/3] mtd: nand: Force omap_elm to be built as a module if omap2_nand is a module"
>
>
Yes. The four lines you have in there
+config MTD_NAND_OMAP_BCH_BUILD
+ tristate
+ depends on MTD_NAND_OMAP2
+ default m if MTD_NAND_OMAP2=m && MTD_NAND_OMAP_BCH
+ default y if MTD_NAND_OMAP2=y && MTD_NAND_OMAP_BCH
should be entirely equivalent to the two lines I wrote above, so my version
is just a readability change, functionally they both are correct as far as
I can tell.
Arnd
prev parent reply other threads:[~2014-10-01 10:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 12:04 [PATCH] nand: omap2: fix building with CONFIG_MTD_NAND_OMAP_BCH=m Arnd Bergmann
2014-10-01 9:32 ` Roger Quadros
2014-10-01 9:56 ` Arnd Bergmann
2014-10-01 10:07 ` Roger Quadros
2014-10-01 10:13 ` Arnd Bergmann
2014-10-01 10:24 ` Roger Quadros
2014-10-01 10:25 ` Ezequiel Garcia
2014-10-01 10:24 ` Ezequiel Garcia
2014-10-01 10:46 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2061777.ebdfGlRHlL@wuerfel \
--to=arnd@arndb.de \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pekon@pek-sem.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox