From: David Woodhouse <dwmw2@infradead.org>
Cc: "Mike Schumi" <schumi@techie.com>, linux-mtd@lists.infradead.org
Subject: Re: jffs2_do_reserve_space
Date: Thu, 25 Jul 2002 18:16:50 +0100 [thread overview]
Message-ID: <21835.1027617410@redhat.com> (raw)
In-Reply-To: <20696.1027616681@redhat.com>
dwmw2@infradead.org said:
> Can you try this?
Or this version if you're using the stable branch...
As I said in private mail, I suspect you've written your jffs2 image to the
flash 0x40 bytes out of place, and the printk in this sanity check isn't
actually correct for you, although it will be for most people who trigger
it.
Index: scan.c
===================================================================
RCS file: /home/cvs/mtd/fs/jffs2/scan.c,v
retrieving revision 1.51.2.2
diff -u -p -r1.51.2.2 scan.c
--- scan.c 23 Feb 2002 13:34:31 -0000 1.51.2.2
+++ scan.c 25 Jul 2002 17:15:16 -0000
@@ -261,6 +261,16 @@ static int jffs2_scan_eraseblock (struct
continue;
}
+ if (ofs + node.totlen > jeb->offset + c->sector_size) {
+ /* Eep. Node goes over the end of the erase block. */
+ printk(KERN_WARNING "Node at 0x%08x with length 0x%08x would run over the end of the erase block\n",
+ ofs, node.totlen);
+ printk(KERN_WARNING "Perhaps the file system was created with the wrong erase size?");
+ DIRTY_SPACE(4);
+ ofs += 4;
+ continue;
+ }
+
switch(node.nodetype | JFFS2_NODE_ACCURATE) {
case JFFS2_NODETYPE_INODE:
err = jffs2_scan_inode_node(c, jeb, &ofs);
--
dwmw2
next prev parent reply other threads:[~2002-07-25 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-25 14:18 jffs2_do_reserve_space Mike Schumi
2002-07-25 17:04 ` jffs2_do_reserve_space David Woodhouse
2002-07-25 17:16 ` David Woodhouse [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-07-25 18:47 jffs2_do_reserve_space Mike Schumi
2002-07-25 20:50 ` jffs2_do_reserve_space David Woodhouse
2002-07-24 20:04 jffs2_do_reserve_space Mike Schumi
2002-07-25 6:40 ` jffs2_do_reserve_space David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21835.1027617410@redhat.com \
--to=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=schumi@techie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox