From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dell-paw-3.cambridge.redhat.com ([195.224.55.237] helo=passion.cambridge.redhat.com) by pentafluge.infradead.org with esmtp (Exim 3.22 #1 (Red Hat Linux)) id 16fz6Q-0006Zq-00 for ; Wed, 27 Feb 2002 08:06:18 +0000 From: David Woodhouse In-Reply-To: <00b301c1bf61$31048fc0$da9240d5@jocke> References: <00b301c1bf61$31048fc0$da9240d5@jocke> <02022614424803.15969@jocke.lumentis.se> <0111121314140A.28381@jocke.lumentis.se> <02010409585400.10979@jocke.lumentis.se> <02012911331100.15969@jocke.lumentis.se> <17624.1014738778@redhat.com> To: "Joakim Tjernlund" Cc: linux-mtd@lists.infradead.org Subject: Re: scan.c & ACCURATE Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 27 Feb 2002 08:17:34 +0000 Message-ID: <22139.1014797854@redhat.com> Sender: linux-mtd-admin@lists.infradead.org Errors-To: linux-mtd-admin@lists.infradead.org List-Help: List-Post: List-Subscribe: , List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: Joakim.Tjernlund@lumentis.se said: > > You're trusting ri.totlen before verifying ri.node_crc. Naughty. > Totlen has been checked by jffs2_scan_eraseblock() before calling > jffs2_scan_inode_node(), but that is not obvious. Move it to after the > CRC check if you like. Sorry, was confusing node_crc with hdr_crc. You're absolutely right. What I've actually done is move the logic to jffs2_erase_eraseblock(), and made it trigger for all types of node. -- dwmw2