From: Arnd Bergmann <arnd@arndb.de>
To: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: avoid stack overflow in MTD CFI code
Date: Sat, 05 Mar 2016 00:25:24 +0100 [thread overview]
Message-ID: <2259988.Lj3BC6sPv6@wuerfel> (raw)
In-Reply-To: <20160304212159.GA55664@google.com>
On Friday 04 March 2016 13:21:59 Brian Norris wrote:
>
> Looking a little closer at this... why do we need the changes to
> include/linux/mtd/map.h again? It should be fine to leave these
> definitions as-is, right? They don't contribute to the large stack
> usage, do they?
>
> Maybe I'm just missing something obvious, so please do enlighten
>
It's been a while since I created the patch, and the originally
failing configuration currently doesn't produce this (probably
because something else changed). I remember that it was something
rather subtle, but don't exactly remember what happened.
I've reverted the patch now, trying to reproduce it on my
randconfig setup, but I might not be able to get back to you
in the next week while I'm traveling.
Arnd
next prev parent reply other threads:[~2016-03-04 23:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 12:20 [PATCH v2] mtd: avoid stack overflow in MTD CFI code Arnd Bergmann
2016-03-04 21:21 ` Brian Norris
2016-03-04 23:25 ` Arnd Bergmann [this message]
2016-03-18 17:44 ` Brian Norris
2016-03-18 20:25 ` Arnd Bergmann
2016-04-04 6:51 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2259988.Lj3BC6sPv6@wuerfel \
--to=arnd@arndb.de \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox