From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lithops.sigma-star.at ([195.201.40.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gIguI-00050b-HC for linux-mtd@lists.infradead.org; Fri, 02 Nov 2018 21:23:08 +0000 From: Richard Weinberger To: Daniel Walker Cc: Richard Weinberger , Al Viro , nkela@cisco.com, xe-linux-external@cisco.com, LKML , linux-mtd@lists.infradead.org, Rod Whitby , David Woodhouse Subject: Re: [PATCH] Make JFFS2 endianness configurable Date: Fri, 02 Nov 2018 22:22:53 +0100 Message-ID: <2265901.Da3O5o3T4q@blindfold> In-Reply-To: <20181102211444.nqqqbd4w5diyqrfw@zorba> References: <20181101225603.17806-1-nkela@cisco.com> <20181102211444.nqqqbd4w5diyqrfw@zorba> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Am Freitag, 2. November 2018, 22:14:44 CET schrieb Daniel Walker: > > Make it a mount option and store the endianness mode in the super block. > > It's actually a mkfs option currently. I'm not sure how that factors in, > > from the mkfs.jffs2 man page, > > -l, --little-endian > Create a little-endian JFFS2 image. Default is to make an image with the same endianness as the host. > > -b, --big-endian > Create a big-endian JFFS2 image. Default is to make an image with the same endianness as the host. As long this setting is not stored in the filesystem itself, it is useless. IIRC it just controls the endianness setting for mkfs.jffs2's t32() and t16() macros. That's why I think of a mount option like "force_endian=". Thanks, //richard